New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better sync the value of `MaximumCompatibleNDKMajorVersion` with the one set in xaprepare #172

Open

pjcollins opened this issue Jun 14, 2022 · 0 comments

Member

pjcollins commented Jun 14, 2022

We should figure out a better way to make sure to keep the max supported NDK version in sync across products.

We bumped xamarin-android to NDK 24 recently in https://github.com/xamarin/xamarin-android/blob/286a20e85da7f28cd138ab86a2b46ae7ab54be4f/build-tools/xaprepare/xaprepare/ConfigAndData/BuildAndroidPlatforms.cs#L8, but forgot to update:

xamarin-android-tools/src/Xamarin.Android.Tools.AndroidSdk/Sdks/AndroidSdkBase.cs

Line 14 in 47832f1

const int MaximumCompatibleNDKMajorVersion = 23;

pjcollins mentioned this issue

[Xamarin.Android.Tools.AndroidSdk] Permit NDK r24 #171

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment