From 481c620fd7530ae1afd29f425104538385f3310d Mon Sep 17 00:00:00 2001
From: Phillip Carter <pcarter@fastmail.com>
Date: Tue, 17 Nov 2020 13:42:15 -0800
Subject: [PATCH] Add ChangeRefCellDerefToNotExpression code fixer (#10469)

* Add ChangeRefCellDerefToNotExpression code fixer

* Area
---
 CodeFix/ChangeRefCellDerefToNotExpression.fs | 52 ++++++++++++++++++++
 FSharp.Editor.fsproj                         |  1 +
 FSharp.Editor.resx                           |  5 +-
 xlf/FSharp.Editor.cs.xlf                     |  5 ++
 xlf/FSharp.Editor.de.xlf                     |  5 ++
 xlf/FSharp.Editor.es.xlf                     |  5 ++
 xlf/FSharp.Editor.fr.xlf                     |  5 ++
 xlf/FSharp.Editor.it.xlf                     |  5 ++
 xlf/FSharp.Editor.ja.xlf                     |  5 ++
 xlf/FSharp.Editor.ko.xlf                     |  5 ++
 xlf/FSharp.Editor.pl.xlf                     |  5 ++
 xlf/FSharp.Editor.pt-BR.xlf                  |  5 ++
 xlf/FSharp.Editor.ru.xlf                     |  5 ++
 xlf/FSharp.Editor.tr.xlf                     |  5 ++
 xlf/FSharp.Editor.zh-Hans.xlf                |  5 ++
 xlf/FSharp.Editor.zh-Hant.xlf                |  5 ++
 16 files changed, 122 insertions(+), 1 deletion(-)
 create mode 100644 CodeFix/ChangeRefCellDerefToNotExpression.fs

diff --git a/CodeFix/ChangeRefCellDerefToNotExpression.fs b/CodeFix/ChangeRefCellDerefToNotExpression.fs
new file mode 100644
index 00000000000..0d7b80e9d96
--- /dev/null
+++ b/CodeFix/ChangeRefCellDerefToNotExpression.fs
@@ -0,0 +1,52 @@
+// Copyright (c) Microsoft Corporation.  All Rights Reserved.  See License.txt in the project root for license information.
+
+namespace Microsoft.VisualStudio.FSharp.Editor
+
+open System.Composition
+open System.Threading.Tasks
+
+open Microsoft.CodeAnalysis.Text
+open Microsoft.CodeAnalysis.CodeFixes
+
+[<ExportCodeFixProvider(FSharpConstants.FSharpLanguageName, Name = "ChangeRefCellDerefToNotExpression"); Shared>]
+type internal FSharpChangeRefCellDerefToNotExpressionCodeFixProvider
+    [<ImportingConstructor>]
+    (
+        checkerProvider: FSharpCheckerProvider, 
+        projectInfoManager: FSharpProjectOptionsManager
+    ) =
+    inherit CodeFixProvider()
+    
+    static let userOpName = "FSharpChangeRefCellDerefToNotExpressionCodeFix"
+    let fixableDiagnosticIds = set ["FS0001"]
+
+    override __.FixableDiagnosticIds = Seq.toImmutableArray fixableDiagnosticIds
+
+    override this.RegisterCodeFixesAsync context : Task =
+        asyncMaybe {
+            let document = context.Document
+            let! parsingOptions, _ = projectInfoManager.TryGetOptionsForEditingDocumentOrProject(document, context.CancellationToken, userOpName)
+            let! sourceText = context.Document.GetTextAsync(context.CancellationToken)
+            let! parseResults = checkerProvider.Checker.ParseFile(document.FilePath, sourceText.ToFSharpSourceText(), parsingOptions, userOpName) |> liftAsync
+
+            let errorRange = RoslynHelpers.TextSpanToFSharpRange(document.FilePath, context.Span, sourceText)
+            let! derefRange = parseResults.TryRangeOfRefCellDereferenceContainingPos errorRange.Start
+            let! derefSpan = RoslynHelpers.TryFSharpRangeToTextSpan(sourceText, derefRange)
+            
+            let title = SR.UseNotForNegation()
+
+            let diagnostics =
+                context.Diagnostics
+                |> Seq.filter (fun x -> fixableDiagnosticIds |> Set.contains x.Id)
+                |> Seq.toImmutableArray
+
+            let codeFix =
+                CodeFixHelpers.createTextChangeCodeFix(
+                    title,
+                    context,
+                    (fun () -> asyncMaybe.Return [| TextChange(derefSpan, "not ") |]))
+
+            context.RegisterCodeFix(codeFix, diagnostics)
+        }
+        |> Async.Ignore
+        |> RoslynHelpers.StartAsyncUnitAsTask(context.CancellationToken) 
\ No newline at end of file
diff --git a/FSharp.Editor.fsproj b/FSharp.Editor.fsproj
index b7a653b0b44..f7cb5d028d3 100644
--- a/FSharp.Editor.fsproj
+++ b/FSharp.Editor.fsproj
@@ -180,6 +180,7 @@
     <Compile Include="Commands\FsiCommandService.fs" />
     <Compile Include="Commands\XmlDocCommandService.fs" />
     <Compile Include="CodeFix\CodeFixHelpers.fs" />
+    <Compile Include="CodeFix\ChangeRefCellDerefToNotExpression.fs" />
     <Compile Include="CodeFix\WrapExpressionInParentheses.fs" />
     <Compile Include="CodeFix\ChangePrefixNegationToInfixSubtraction.fs" />
     <Compile Include="CodeFix\AddNewKeywordToDisposableConstructorInvocation.fs" />
diff --git a/FSharp.Editor.resx b/FSharp.Editor.resx
index 802675e062e..94f2d6c4c58 100644
--- a/FSharp.Editor.resx
+++ b/FSharp.Editor.resx
@@ -1,4 +1,4 @@
-<?xml version="1.0" encoding="utf-8"?>
+<?xml version="1.0" encoding="utf-8"?>
 <root>
   <!-- 
     Microsoft ResX Schema 
@@ -219,6 +219,9 @@
   <data name="FSharpDisposableTopLevelValuesClassificationType" xml:space="preserve">
     <value>F# Dispostable Values (top-level)</value>
   </data>
+  <data name="UseNotForNegation" xml:space="preserve">
+    <value>Use 'not' to negate expression</value>
+  </data>
   <data name="WrapExpressionInParentheses" xml:space="preserve">
     <value>Wrap expression in parentheses</value>
   </data>
diff --git a/xlf/FSharp.Editor.cs.xlf b/xlf/FSharp.Editor.cs.xlf
index d5486f6aac4..b1c154e6166 100644
--- a/xlf/FSharp.Editor.cs.xlf
+++ b/xlf/FSharp.Editor.cs.xlf
@@ -177,6 +177,11 @@
         <target state="translated">Formátování</target>
         <note />
       </trans-unit>
+      <trans-unit id="UseNotForNegation">
+        <source>Use 'not' to negate expression</source>
+        <target state="new">Use 'not' to negate expression</target>
+        <note />
+      </trans-unit>
       <trans-unit id="WrapExpressionInParentheses">
         <source>Wrap expression in parentheses</source>
         <target state="new">Wrap expression in parentheses</target>
diff --git a/xlf/FSharp.Editor.de.xlf b/xlf/FSharp.Editor.de.xlf
index b66b9951e47..728a4f2e556 100644
--- a/xlf/FSharp.Editor.de.xlf
+++ b/xlf/FSharp.Editor.de.xlf
@@ -177,6 +177,11 @@
         <target state="translated">Formatierung</target>
         <note />
       </trans-unit>
+      <trans-unit id="UseNotForNegation">
+        <source>Use 'not' to negate expression</source>
+        <target state="new">Use 'not' to negate expression</target>
+        <note />
+      </trans-unit>
       <trans-unit id="WrapExpressionInParentheses">
         <source>Wrap expression in parentheses</source>
         <target state="new">Wrap expression in parentheses</target>
diff --git a/xlf/FSharp.Editor.es.xlf b/xlf/FSharp.Editor.es.xlf
index ebe2cb49dbd..3a42ab5f955 100644
--- a/xlf/FSharp.Editor.es.xlf
+++ b/xlf/FSharp.Editor.es.xlf
@@ -177,6 +177,11 @@
         <target state="translated">Formato</target>
         <note />
       </trans-unit>
+      <trans-unit id="UseNotForNegation">
+        <source>Use 'not' to negate expression</source>
+        <target state="new">Use 'not' to negate expression</target>
+        <note />
+      </trans-unit>
       <trans-unit id="WrapExpressionInParentheses">
         <source>Wrap expression in parentheses</source>
         <target state="new">Wrap expression in parentheses</target>
diff --git a/xlf/FSharp.Editor.fr.xlf b/xlf/FSharp.Editor.fr.xlf
index 8a24580b08e..9dc3d3c8256 100644
--- a/xlf/FSharp.Editor.fr.xlf
+++ b/xlf/FSharp.Editor.fr.xlf
@@ -177,6 +177,11 @@
         <target state="translated">Mise en forme</target>
         <note />
       </trans-unit>
+      <trans-unit id="UseNotForNegation">
+        <source>Use 'not' to negate expression</source>
+        <target state="new">Use 'not' to negate expression</target>
+        <note />
+      </trans-unit>
       <trans-unit id="WrapExpressionInParentheses">
         <source>Wrap expression in parentheses</source>
         <target state="new">Wrap expression in parentheses</target>
diff --git a/xlf/FSharp.Editor.it.xlf b/xlf/FSharp.Editor.it.xlf
index b6cadf4482c..03e9a26b0a3 100644
--- a/xlf/FSharp.Editor.it.xlf
+++ b/xlf/FSharp.Editor.it.xlf
@@ -177,6 +177,11 @@
         <target state="translated">Formattazione</target>
         <note />
       </trans-unit>
+      <trans-unit id="UseNotForNegation">
+        <source>Use 'not' to negate expression</source>
+        <target state="new">Use 'not' to negate expression</target>
+        <note />
+      </trans-unit>
       <trans-unit id="WrapExpressionInParentheses">
         <source>Wrap expression in parentheses</source>
         <target state="new">Wrap expression in parentheses</target>
diff --git a/xlf/FSharp.Editor.ja.xlf b/xlf/FSharp.Editor.ja.xlf
index 9029587aabc..94a636ea333 100644
--- a/xlf/FSharp.Editor.ja.xlf
+++ b/xlf/FSharp.Editor.ja.xlf
@@ -177,6 +177,11 @@
         <target state="translated">書式設定</target>
         <note />
       </trans-unit>
+      <trans-unit id="UseNotForNegation">
+        <source>Use 'not' to negate expression</source>
+        <target state="new">Use 'not' to negate expression</target>
+        <note />
+      </trans-unit>
       <trans-unit id="WrapExpressionInParentheses">
         <source>Wrap expression in parentheses</source>
         <target state="new">Wrap expression in parentheses</target>
diff --git a/xlf/FSharp.Editor.ko.xlf b/xlf/FSharp.Editor.ko.xlf
index 6c18283919e..9bc5464d9a8 100644
--- a/xlf/FSharp.Editor.ko.xlf
+++ b/xlf/FSharp.Editor.ko.xlf
@@ -177,6 +177,11 @@
         <target state="translated">서식</target>
         <note />
       </trans-unit>
+      <trans-unit id="UseNotForNegation">
+        <source>Use 'not' to negate expression</source>
+        <target state="new">Use 'not' to negate expression</target>
+        <note />
+      </trans-unit>
       <trans-unit id="WrapExpressionInParentheses">
         <source>Wrap expression in parentheses</source>
         <target state="new">Wrap expression in parentheses</target>
diff --git a/xlf/FSharp.Editor.pl.xlf b/xlf/FSharp.Editor.pl.xlf
index 94e101a86e6..aff222fbe9c 100644
--- a/xlf/FSharp.Editor.pl.xlf
+++ b/xlf/FSharp.Editor.pl.xlf
@@ -177,6 +177,11 @@
         <target state="translated">Formatowanie</target>
         <note />
       </trans-unit>
+      <trans-unit id="UseNotForNegation">
+        <source>Use 'not' to negate expression</source>
+        <target state="new">Use 'not' to negate expression</target>
+        <note />
+      </trans-unit>
       <trans-unit id="WrapExpressionInParentheses">
         <source>Wrap expression in parentheses</source>
         <target state="new">Wrap expression in parentheses</target>
diff --git a/xlf/FSharp.Editor.pt-BR.xlf b/xlf/FSharp.Editor.pt-BR.xlf
index dedf532aedc..6c9a2e0bda9 100644
--- a/xlf/FSharp.Editor.pt-BR.xlf
+++ b/xlf/FSharp.Editor.pt-BR.xlf
@@ -177,6 +177,11 @@
         <target state="translated">Formatação</target>
         <note />
       </trans-unit>
+      <trans-unit id="UseNotForNegation">
+        <source>Use 'not' to negate expression</source>
+        <target state="new">Use 'not' to negate expression</target>
+        <note />
+      </trans-unit>
       <trans-unit id="WrapExpressionInParentheses">
         <source>Wrap expression in parentheses</source>
         <target state="new">Wrap expression in parentheses</target>
diff --git a/xlf/FSharp.Editor.ru.xlf b/xlf/FSharp.Editor.ru.xlf
index 1207c51d09f..5b061944686 100644
--- a/xlf/FSharp.Editor.ru.xlf
+++ b/xlf/FSharp.Editor.ru.xlf
@@ -177,6 +177,11 @@
         <target state="translated">Форматирование</target>
         <note />
       </trans-unit>
+      <trans-unit id="UseNotForNegation">
+        <source>Use 'not' to negate expression</source>
+        <target state="new">Use 'not' to negate expression</target>
+        <note />
+      </trans-unit>
       <trans-unit id="WrapExpressionInParentheses">
         <source>Wrap expression in parentheses</source>
         <target state="new">Wrap expression in parentheses</target>
diff --git a/xlf/FSharp.Editor.tr.xlf b/xlf/FSharp.Editor.tr.xlf
index 19c41424348..7266f9c201e 100644
--- a/xlf/FSharp.Editor.tr.xlf
+++ b/xlf/FSharp.Editor.tr.xlf
@@ -177,6 +177,11 @@
         <target state="translated">Biçimlendirme</target>
         <note />
       </trans-unit>
+      <trans-unit id="UseNotForNegation">
+        <source>Use 'not' to negate expression</source>
+        <target state="new">Use 'not' to negate expression</target>
+        <note />
+      </trans-unit>
       <trans-unit id="WrapExpressionInParentheses">
         <source>Wrap expression in parentheses</source>
         <target state="new">Wrap expression in parentheses</target>
diff --git a/xlf/FSharp.Editor.zh-Hans.xlf b/xlf/FSharp.Editor.zh-Hans.xlf
index 14605a7064c..af1ab1fd54c 100644
--- a/xlf/FSharp.Editor.zh-Hans.xlf
+++ b/xlf/FSharp.Editor.zh-Hans.xlf
@@ -177,6 +177,11 @@
         <target state="translated">正在格式化</target>
         <note />
       </trans-unit>
+      <trans-unit id="UseNotForNegation">
+        <source>Use 'not' to negate expression</source>
+        <target state="new">Use 'not' to negate expression</target>
+        <note />
+      </trans-unit>
       <trans-unit id="WrapExpressionInParentheses">
         <source>Wrap expression in parentheses</source>
         <target state="new">Wrap expression in parentheses</target>
diff --git a/xlf/FSharp.Editor.zh-Hant.xlf b/xlf/FSharp.Editor.zh-Hant.xlf
index 3e89e5c086c..abf9dcb7465 100644
--- a/xlf/FSharp.Editor.zh-Hant.xlf
+++ b/xlf/FSharp.Editor.zh-Hant.xlf
@@ -177,6 +177,11 @@
         <target state="translated">格式化</target>
         <note />
       </trans-unit>
+      <trans-unit id="UseNotForNegation">
+        <source>Use 'not' to negate expression</source>
+        <target state="new">Use 'not' to negate expression</target>
+        <note />
+      </trans-unit>
       <trans-unit id="WrapExpressionInParentheses">
         <source>Wrap expression in parentheses</source>
         <target state="new">Wrap expression in parentheses</target>