[generator] Refactor enum writing to use SourceWriters. #1063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonpryor
pushed a commit
to xamarin/xamarin-android
that referenced
this pull request
Dec 12, 2022
Changes: xamarin/java.interop@3a9f770...149d70f * xamarin/java.interop@149d70fe: [generator] Refactor enum writing to use SourceWriters (xamarin/java.interop#1063) * xamarin/java.interop@c2daa9f0: [Java.Interop.Tools.Cecil] DirectoryAssemblyResolver & File.Exists() (xamarin/java.interop#1065) * xamarin/java.interop@8ab9d33a: [Java.Interop.Tools.TypeNameMappings] improve `ToJniNameFromAttributesForAndroid` (xamarin/java.interop#1064) * xamarin/java.interop@09f8da26: [JavaCallableWrappers] avoid `string.Format()` (xamarin/java.interop#1061) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor
EnumGeneratorto use SourceWriters instead of a directTextWriter. This will make it possible to use our existing code to apply[PlatformOSSupported]attributes to enums in a future PR.This is a separate PR to help verify there was no output changed from the refactor.
Tested with ApiCompat on xamarin/xamarin-android#7619 to help ensure no changes.