Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FPP Connect assumes port 80, cannot connect to any other port #4449

Open
EvilfishInsane opened this issue Apr 1, 2024 · 2 comments
Open

Comments

@EvilfishInsane
Copy link

EvilfishInsane commented Apr 1, 2024

Describe the bug
I am using the FPP player through the docker image. I deployed the docker in my system, and after some setup, I tried to connect to it through the FPP Connect option under Tools.

When I entered my IP for the player with port 192.168.1.89:2412 nothing happens. If I tried just with the IP I do get a brief loading box:

image

But nothing happens, but this was kind of expected as the port was not 80. If I change the port to 80 in my docker system, then it works fine:

image

Now, yes, I could just use port 80, but as I might have some plans that need port 80 for something else, this is suddenly a problem. Could we include the possibility to use a port number to connect to a FFP running in a docker container?

To Reproduce
These steps assumes that a docker container system is installed and running. Also make sure firewall is not an issue.
0. Pull the container

docker pull falconchristmas/fpp
  1. Start FFP container with port exposing port 2412 or something none 80 for ease docker-compose.tml provided:
version: '3'
services:
  fpp:
    image: falconchristmas/fpp
    ports:
      - "2412:80"
    volumes:
      - type: bind
        source: <pathToLocalDirectory>
        target: /home/fpp/media
sudo docker-compose up -d
  1. Try to connect to falcon player from xlight using the FPP Connect. Try with and without port. Observe no connection.
  2. Shut down the container
sudo docker-compose down
  1. Edit the docker-compose file:
version: '3'
services:
  fpp:
    image: falconchristmas/fpp
    ports:
      - "80:80"
    volumes:
      - type: bind
        source: <pathToLocalDirectory>
        target: /home/fpp/media
  1. Start container again
sudo docker-compose up -d
  1. Try to connect to falcon player from xlight using the FPP Connect, see it works.

Expected behavior
I would have liked to see that if you search for FFP at x.x.x.x:port and the port was anything else than 80, then it would work.

Versions (please complete the following information):

  • OS: Windows 10
  • xLights version 2024.06 64 bit
@derwin12
Copy link
Collaborator

derwin12 commented Apr 1, 2024

Assuming you meant 192.168.1.89:2412 colon not semi-colon. And that doesnt work?

@EvilfishInsane
Copy link
Author

That was a typo, fixed the post, and also verified I haven't used semicolon in my test. I cannot connect with FFP Connect with a port defined like 192.168.1.89:2412

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants