Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add care about old version of did_you_mean #637

Merged
merged 1 commit into from Nov 10, 2018

Conversation

y-yagi
Copy link
Member

@y-yagi y-yagi commented Nov 10, 2018

DidYouMean::SpellChecker class added by v1.0.2.
https://github.com/yuki24/did_you_mean/blob/master/CHANGELOG.md#v102

Therefore, even if can use did_you_mean, may not be able to use
DidYouMean::SpellChecker. For that case, also ignored NameError.

`DidYouMean::SpellChecker` class added by `v1.0.2`.
https://github.com/yuki24/did_you_mean/blob/master/CHANGELOG.md#v102

Therefore, even if can use `did_you_mean`, may not be able to use
`DidYouMean::SpellChecker`. For that case, also ignored `NameError`.
@y-yagi
Copy link
Member Author

y-yagi commented Nov 10, 2018

cc @rafaelfranca

@rafaelfranca rafaelfranca merged commit 8c1fae2 into rails:master Nov 10, 2018
@y-yagi y-yagi deleted the add_care_of_old_did_you_mean branch November 10, 2018 02:44
@mathieujobin
Copy link

Anyone tested if this fix bundler-audit?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants