New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing types for the Exception class properties #1583
Conversation
Thanks for the PR. Test cases for the typings go into the |
OK. I'll add some. |
@nknapp I've added some code using the defined types in the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adapting my change requests. I have now had a chance to have a closer look and I would you to make further changes. Please have a look at my review comments.
@nknapp Thanks for the detail review. I'll make the changes push again. |
34f3b8f
to
168d4f9
Compare
Hi @nknapp I've pushed new changes as per your suggestions. Could you please review again and let me know if this looks good? Thanks! |
Superb. Merging now. |
Resolves #1576
Add missing type declarations for the properties of
Exception
class.What has changed?
function
to aclass
so as to declare fields.this
object in the source file.node
of typehbs.AST.Node
.4.x
-branch contains the latest version. Please target that branch in the PR.@nknapp Not sure if this change requires a test too. If yes, please suggest and show me some examples and I can do it. Thanks!
PS: I tried
npm checkTypes
andnpm test
which all passed for me - not sure what else I need to do.