Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Further security issue #1563

Closed
4 tasks
nknapp opened this issue Sep 26, 2019 · 6 comments
Closed
4 tasks

Further security issue #1563

nknapp opened this issue Sep 26, 2019 · 6 comments

Comments

@nknapp
Copy link
Collaborator

nknapp commented Sep 26, 2019

Disallows calls to the helperMissing-helpers (#1558) didn't solve all the problem and another exploit was reported.

The exploit will be released well after the fix is in place to give people a chance to update.

Before filing issues, please check the following points first:

This will probably help you to get a solution faster.
For bugs, it would be great to have a PR with a failing test-case.

nknapp added a commit that referenced this issue Sep 26, 2019
- context.propertyIsEnumerable can be replaced
  via __definedGetter__
- This is a fix specific to counter a known RCE exploit.
  Other fixes will follow.

closes #1563
@XhmikosR
Copy link

Is this fixed by 4.3.3?

@nknapp
Copy link
Collaborator Author

nknapp commented Sep 27, 2019

All proofs-of-concept that I have received so far are not working anymore with 4.3.3

I am still trying to work out if there are any ways circumvent my fixes. I cannot say for certain that everything is fixed.

@nknapp
Copy link
Collaborator Author

nknapp commented Sep 29, 2019

I have reported the fix of this issue to npm only yesterday. It may take them until next week to update the audit-database.

@nknapp nknapp closed this as completed Sep 29, 2019
@NicoleG25
Copy link

NicoleG25 commented Jan 9, 2020

Ah @nknapp , just came across this.. would you be able to confirm if there was a fix for CVE-2019-19919 made and if so in what commit/version release?

Thanks in advance !

@nknapp
Copy link
Collaborator Author

nknapp commented Jan 9, 2020

The npm advisory that is references in the CVE was resolved in 4.3.0.

There were variations that were possible until 4.5.3.

4.6.0 now provides a more complete solution.

I think the npm-security advisories give a more complete picture than CVEs.

@NicoleG25
Copy link

NicoleG25 commented Jan 9, 2020

The npm advisory that is references in the CVE was resolved in 4.3.0.

There were variations that were possible until 4.5.3.

4.6.0 now provides a more complete solution.

I think the npm-security advisories give a more complete picture than CVEs.

Thanks for the quick response,
Was there another npm-security advisory issue opened for those variations that are now completely fixed in 4.6.0 or is the same issue referring to all of them?

Also, would you be able to kindly point out the commit fixing the issue in 4.6.0? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants