Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure codebase conforms to standard.rb style guide #141

Merged
merged 26 commits into from Apr 15, 2019
Merged

Make sure codebase conforms to standard.rb style guide #141

merged 26 commits into from Apr 15, 2019

Conversation

wvanbergen
Copy link
Owner

Use standard.rb (see https://github.com/testdouble/standard) as code style for the project. There are a couple of exceptions that are properly documented, but other than that all the violations have been fixed.

@wvanbergen
Formatting
9f7d1ef
@wvanbergen
standard.rb: Spacing around operators.
ae05365
@wvanbergen
standard.rb: Fix spacing issues.
a2110ec
@wvanbergen
standard.rb: Use is_a? instead of kind_of?
769b311
@wvanbergen
stadard.rb: Fix missing spacing around commas.
91f5c0e
@wvanbergen
standard.rb: Add trailing commas to array literals, reformat where ne…
8efdba4 
…eded.
@wvanbergen
standrad.rb: Use { … } block syntax.
4d1af58
@wvanbergen
standard.rb: Fix spacing inside array literals.
e2788e3
@wvanbergen
standard.rb: Remove unnecessary empty lines.
b1876ce
@wvanbergen
standard.rb: remove unnecessary require statement.
0d6e8b5
@wvanbergen
standard.rb: Manually disabled some Rubocop rules for some lines.
108f801
@wvanbergen
standard.rb: Fix spacing issues
b9c34fa
@wvanbergen
standard.rb: Various style fixes
7cb14ba
@wvanbergen
standard.rb: Fix some parameter alignment issues.
b431cb3
@wvanbergen
standard.rb: Fix some small style issue sin drawing.rb
de83806
@wvanbergen
standard.rb: Remove unnecessary parentheses.
219369a
@wvanbergen
Fix some specs that were not properly converted to should syntax.
1e34404
@wvanbergen
standard.rb: Allow some exceptions on Rubocop spacing rules for bette…
a2a9faf 
…r alignment of arguments in some code blocks.
@wvanbergen
standard.rb: Use delete rather then unneeded gsub to delete newli…
1e5cf92 
…nes.
@wvanbergen
standard.rb: Don’t use nested ternary operators.
c90fcc6
@wvanbergen
Fix yardoc description of ChunkyPNG::OutOfBounds exception class.
07c48e4
@wvanbergen
standard.rb: Fix unnecessary else clauses.
0a60707
@wvanbergen
standard.rb: Various style fixes.
9e28ec7
@wvanbergen
standard.rb: Avoid ambiguous - operator.
c6ac130
@wvanbergen
standard.rb: Consistently use double quotes for strings.
ef47fb4
@wvanbergen
Add standard.rb configuration file.
7511a51
@wvanbergen wvanbergen merged commit b982285 into master Apr 15, 2019
@wvanbergen wvanbergen deleted the standardrb branch April 15, 2019 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@wvanbergen