Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for nodeSelector, tolerations, affinity, and resources (limits/requests) in migration jobs #692

Open
BrianSiimAndersenEG opened this issue Apr 4, 2024 · 3 comments
Labels
enhancement New feature or request internally-reviewed The issue has been reviewed internally.

Comments

@BrianSiimAndersenEG
Copy link

Component(s)

helm

Is your feature request related to a problem? Please describe.

In the Helm charts for all the components for the Cosmo platform it is possible to override tolerations, affinity, and resources through values.yaml. This is not possible for the charts for the migration jobs. We're installing in a cluster which requires us to specify resource limits, and need to run in a node other that the default node.

Describe the solution you'd like

We would like to be able to specify properties in the values.yaml for nodeSelector, tolerations, affinity, and resources and use those values within the charts for the migration jobs, so that we are able to run the migrations in specific nodes - like it is possible with the other charts.

Describe alternatives you've considered

No response

Additional context

No response

@BrianSiimAndersenEG BrianSiimAndersenEG added the enhancement New feature or request label Apr 4, 2024
Copy link

github-actions bot commented Apr 4, 2024

WunderGraph commits fully to Open Source and we want to make sure that we can help you as fast as possible.
The roadmap is driven by our customers and we have to prioritize issues that are important to them.
You can influence the priority by becoming a customer. Please contact us here.

@Aenimus
Copy link
Member

Aenimus commented Apr 9, 2024

Hi @BrianSiimAndersenEG

Please could you elaborate on your use case?

Thanks!

@Aenimus Aenimus added the internally-reviewed The issue has been reviewed internally. label Apr 9, 2024
@BrianSiimAndersenEG
Copy link
Author

Hi @Aenimus - sorry for the long response time.

In the cluster we have multiple namespaces and the default node is very restricted. In the values.yaml for all the components, your Helm chart makes it possible to specify tolerations, affinity, and resources. We use that to make the components run in given nodes, and our cluster is also set up, so that we have to specify the resources. This is working perfectly with all the components.

The "problem" is the migrations, that are running. As a workaround our cluster configuration has been changes, so that it's less restrictive, but we would very much like the opportunity to specify the mentioned properties for the migrations, in order for them to run in a specific node - which we handle through tolerations and affinity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request internally-reviewed The issue has been reviewed internally.
Projects
None yet
Development

No branches or pull requests

2 participants