fix: database creation in clickhouse #567
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxkomarychev
force-pushed
the
fix-seeding-clickhouse
branch
2 times, most recently
from
5b91bd6
to
3b332c8
Compare
maxkomarychev
force-pushed
the
fix-seeding-clickhouse
branch
from
3b332c8
to
c083571
Compare
maxkomarychev
changed the title
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
Hi @maxkomarychev, I was able to reproduce it on a Mac. I don't know why it didn't fail in the CI. Must be a regression in the clickhouse image. |
|
@maxkomarychev thank you for the PR. I had to do several other things to make the clickhouse migration working. The is released today. Please give it a try. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Fixes #566
Currently database in clickhouse is not being created because sql files are not allowed in
initdbScripts:TODO