Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Name of the subgraph request #542

Open
flymedllva opened this issue Feb 16, 2024 · 3 comments
Open

Name of the subgraph request #542

flymedllva opened this issue Feb 16, 2024 · 3 comments
Labels
enhancement New feature or request internally-reviewed The issue has been reviewed internally.

Comments

@flymedllva
Copy link

flymedllva commented Feb 16, 2024

Component(s)

router

Is your feature request related to a problem? Please describe.

In the subgraph, it is not clear what kind of request came to him, I want to draw beautiful metrics

Current queries in subgraphs do not contain information about the name of the query at all

supergraph query:

query Test {
  testField
}

subgraph query:

{"query":"{testField}"}

Describe the solution you'd like

Do it like in the Apollo Rover

Requests must contain the name of the parent request and information about nesting

Query Test__service_name__3
Query Test__service_name__2
Query Test__service_name__0

Describe alternatives you've considered

No response

Additional context

No response

@flymedllva flymedllva added the enhancement New feature or request label Feb 16, 2024
Copy link

WunderGraph commits fully to Open Source and we want to make sure that we can help you as fast as possible.
The roadmap is driven by our customers and we have to prioritize issues that are important to them.
You can influence the priority by becoming a customer. Please contact us here.

@StarpTech
Copy link
Contributor

Is there any reason why you're not using our OTEL integration? There we provide this information and more.

@StarpTech StarpTech added the internally-reviewed The issue has been reviewed internally. label Feb 19, 2024
@flymedllva
Copy link
Author

flymedllva commented Feb 26, 2024

We want to use only router and we only need our own metrics unified for all our golang services.
Since router goes to our subgraphs via HTTP, for drawing metrics of a subgraph service we need to know what request came (its name), otherwise all requests look like they came to /graphql.
Here is an example of how we see our requests if Apollo Rover comes to the subgraph
Screenshot 2024-02-26 at 13 54 39
That is, we just seem to have nowhere to get the name of the query other than putting in the headers from the module

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request internally-reviewed The issue has been reviewed internally.
Projects
None yet
Development

No branches or pull requests

2 participants