Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request comes after the accidental closing of #628 and fixes #490. I cherry-picked the commits of #628 so the author is remembered.
Basically this patch renders the
RadioField
render_kw
parameter in both the generated<ul>
tag, and the<input type="radio">
tags inside. Before it was rendered only in<ul>
and not in the<input>
.Passing
disabled=True
in therender_kw
will keep adding adisabled
parameter in<ul>
. This may look wrong but this is harmless and not worse than before.I am not sure how to improve this. For instance, how to ventilate
render_kw
items so some are displayed in<ul>
and other in<input>
? What aboutclass
, should this be rendered in both?I think the situation is still unsatisfying with this patch, but at least it goes in the right direction. It is a good-enough PR in my opinion.
What do you think?