Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pass RadioField (SelectFieldBase) render_kw dict in _Option class #628

Closed
wants to merge 0 commits into from

Conversation

dizcza
Copy link
Contributor

@dizcza dizcza commented Jun 23, 2020

Describe the issue you are attempting to fix.

RadioField ignores render_rw dict arg. I noticed that when I was trying to pass render_rw=dict(disabled=True) as an argument in RadioField constructor.

Populating _Option with RadioField's .render_kw attribute solves the issue.

However, there is an issue with your testing setup that does not allow me to pass render_rw while creating a radio field to make a regression test.

-_-

@wtforms wtforms deleted a comment from dizcza Jul 8, 2020
tests/test_fields.py Outdated Show resolved Hide resolved
@azmeuk
Copy link
Member

azmeuk commented Oct 4, 2020

With the typo fixed, the test pass without your fix, so your fix does not actually fix your test.

@azmeuk azmeuk added the onhold Waiting feedback label Oct 4, 2020
@dizcza
Copy link
Contributor Author

dizcza commented Oct 4, 2020

@azmeuk There is also an annoying style check. Do I need to follow it blindly?

tests/test_fields.py Outdated Show resolved Hide resolved
@azmeuk
Copy link
Member

azmeuk commented Oct 4, 2020

Yes. But you can simply run black on the files you have edited.

@azmeuk
Copy link
Member

azmeuk commented Oct 4, 2020

This ticket seems related to #490

@dizcza
Copy link
Contributor Author

dizcza commented Oct 4, 2020

Done. Let me know if I need to do anything else.

@dizcza
Copy link
Contributor Author

dizcza commented Oct 5, 2020

Hope that you squash the changes during the merge.

@azmeuk
Copy link
Member

azmeuk commented Apr 27, 2021

Wow. I am not sure how this issue get closed, I just rebased your branch against wtforms master. Now github does not allow me to reopen it.

@davidism
Copy link
Member

I'm not sure how, but this has happened to me a few times too. You might be able to use git reflog to find the branch before you rebased it, then try again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
onhold Waiting feedback
Development

Successfully merging this pull request may close these issues.

None yet

3 participants