We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
In general, some error messages end with a period:
#: src/wtforms/validators.py:269 src/wtforms/validators.py:294 msgid "This field is required." msgstr "" #: src/wtforms/validators.py:327 msgid "Invalid input." msgstr "" #: src/wtforms/validators.py:387 msgid "Invalid email address." msgstr "" #: src/wtforms/validators.py:423 msgid "Invalid IP address." msgstr "" #: src/wtforms/validators.py:466 msgid "Invalid Mac address." msgstr ""
but some don't:
#: src/wtforms/csrf/core.py:96 msgid "Invalid CSRF Token" msgstr "" #: src/wtforms/csrf/session.py:63 msgid "CSRF token missing" msgstr "" #: src/wtforms/csrf/session.py:71 msgid "CSRF failed" msgstr "" #: src/wtforms/csrf/session.py:76 msgid "CSRF token expired" msgstr "" #: src/wtforms/fields/core.py:534 msgid "Invalid Choice: could not coerce" msgstr "" #: src/wtforms/fields/core.py:538 msgid "Choices cannot be None" msgstr "" #: src/wtforms/fields/core.py:545 msgid "Not a valid choice" msgstr ""
source: https://github.com/wtforms/wtforms/blob/master/src/wtforms/locale/wtforms.pot
This make the UI look a little inconsistent when these messages show together.
Do we need to add periods for these messages? If yes, I can submit a PR to fix this. This PR may involve these changes:
The text was updated successfully, but these errors were encountered:
Thank you for your reporting. I suppose it would make sense to have periods everywhere. Your PR is welcome!
Sorry, something went wrong.
tests: wtforms changed error messages
25091a3
In wtforms version >= 2.3.2 localizations where unified with ending dots. From version >=3.0.0 also the english localization was adjusted. 'Not a valid choice' became 'Not a valid choice.', logic added to assert based on version. References: wtforms/wtforms#613 wtforms/wtforms#620 wtforms/wtforms@2.3.2...master wtforms/wtforms@514a972
Successfully merging a pull request may close this issue.
In general, some error messages end with a period:
but some don't:
source: https://github.com/wtforms/wtforms/blob/master/src/wtforms/locale/wtforms.pot
This make the UI look a little inconsistent when these messages show together.
Do we need to add periods for these messages? If yes, I can submit a PR to fix this. This PR may involve these changes:
The text was updated successfully, but these errors were encountered: