SelectField will throw ValueError when using list of strings #598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This give a consistent output of 3 values where using just choices leads to ValueError when choices is a list of strings. By using match from iter_choices we also keep from doing the check twice so there should be no costs here except for the zip() when using lists of strings.
azmeuk
added a commit
to azmeuk/wtforms
that referenced
this pull request
Jul 29, 2020
Merged
rriski
added a commit
to rriski/ihatemoney
that referenced
this pull request
Mar 28, 2024
Error introduced in spiral-project#1290. Fixes spiral-project#1293. WTForms needs to be bumped to >=2.3.2 as it includes a fix to `SelectField` which is required for this change to work. See: - https://wtforms.readthedocs.io/en/3.1.x/changes/#version-2-3-2 - wtforms/wtforms#598
zorun
pushed a commit
to spiral-project/ihatemoney
that referenced
this pull request
Mar 28, 2024
Error introduced in #1290. Fixes #1293. WTForms needs to be bumped to >=2.3.2 as it includes a fix to `SelectField` which is required for this change to work. See: - https://wtforms.readthedocs.io/en/3.1.x/changes/#version-2-3-2 - wtforms/wtforms#598
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This may assist with #464 (at least the behavior described by @ftm in that ticket.)
In the validation phase, we use iter_choices now instead of trying to iterate on choices directly. This will mean that regardless of list of tuples or the shortcut list of strings, we always have 3 values when we iterate the list. We use the match result from iter_choices instead of doing the comparison again to save the operation.
If you are using the shortcut list of strings and getting
'too many values to unpack (expected 2)', this is the fix.I'm doing the following to work around this right now:
list(zip(is required to preventchoicesfrom being an iterator.listTimezones()is a singleton function that returns a cached list of strings. Without thelist(zip(or this patch, this will will always fail to validate.