Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Normalize render attribute names consistently #596

Merged
merged 1 commit into from
May 31, 2020
Merged

Normalize render attribute names consistently #596

merged 1 commit into from
May 31, 2020

Conversation

azmeuk
Copy link
Member

@azmeuk azmeuk commented Apr 25, 2020

Fixes #449

The cleaning of for_, class_ and class__ parameter names is done in DefaultMeta.render_field (instead of html_params), so Field.__call__ arguments can override render_kw.

@azmeuk azmeuk added the bug Unexpected behavior label Apr 25, 2020
davidism
davidism reviewed May 28, 2020
View reviewed changes
src/wtforms/meta.py Outdated Show resolved Hide resolved
src/wtforms/widgets/core.py Show resolved Hide resolved
src/wtforms/widgets/core.py Outdated Show resolved Hide resolved
@azmeuk azmeuk force-pushed the issue-449-override-field-parameters branch 2 times, most recently from 0a18877 to c259a97 Compare May 28, 2020 18:27
@davidism davidism force-pushed the issue-449-override-field-parameters branch from c259a97 to d9ad60c Compare May 31, 2020 06:49
@davidism davidism changed the title Fixed render for for_, class_ and class__ Normalize render attribute names consistently May 31, 2020
@davidism davidism added this to the 3.0.0 milestone May 31, 2020
@davidism davidism merged commit 848d28d into wtforms:master May 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidism davidism davidism left review comments

Assignees
No one assigned
Labels
bug Unexpected behavior
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.

html_params and class and class_
2 participants
@azmeuk @davidism