Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added html5 input field type "month" #530

Closed
wants to merge 6 commits into from

Conversation

rambowtech
Copy link
Contributor

@rambowtech rambowtech commented Dec 12, 2019

There was already a widget defined, but no field available. I added it, so the html5 input type "month" may be utilized.

First time I contribute on Github. I hope everything is correct. Feedback would be appreciated.

@azmeuk
Copy link
Member

azmeuk commented Mar 6, 2020

Hello. Thank you for your contribution.
I suppose a new field would require some tests (to be sure it works, and that future contributions wont break it), and some documentation (maybe a reference in docs/fields.rst would be enough).

You can have a look on DateField tests in tests/test_fields.py for instance.

@azmeuk azmeuk added the onhold Waiting feedback label Apr 18, 2020
@azmeuk azmeuk mentioned this pull request Apr 24, 2020
@azmeuk azmeuk added the enhancement New feature, or existing feature improvement label Apr 24, 2020
@davidism
Copy link
Member

Continued in #593

@davidism davidism closed this May 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature, or existing feature improvement onhold Waiting feedback
Development

Successfully merging this pull request may close these issues.

None yet

3 participants