Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow non-boolean field flags #406

Closed
davidism opened this issue Jun 12, 2018 · 4 comments · Fixed by #467
Closed

Allow non-boolean field flags #406

davidism opened this issue Jun 12, 2018 · 4 comments · Fixed by #467
Labels
enhancement New feature, or existing feature improvement
Milestone

Comments

@davidism
Copy link
Member

I want to support more HTML validation attributes, but currently the flags only set their value to True. For things like maxlength, we need to set the actual value.

My idea is to allow field_flags to be a function which returns a dict, deprecating and eventually removing the old tuple behavior.

@whb07
Copy link
Contributor

whb07 commented Jun 12, 2018

This sounds great! A lot of the HTML5 standards can help reduce the minutiae of server side validations.

@ftm ftm added the enhancement New feature, or existing feature improvement label Jun 13, 2018
@Sohalt
Copy link
Contributor

Sohalt commented Feb 7, 2019

Any progress on this? Would you accept a pull request?

@davidism
Copy link
Member Author

davidism commented Feb 7, 2019

I'd be happy to review a pull request. Just take that as a given for any open issue that is not under discussion and doesn't have a PR already, no need to ask. 😄

@Sohalt
Copy link
Contributor

Sohalt commented Feb 13, 2019

I've opened a pull request. The stylecheck is failing however, because some lines are too long. I'd like to have your opinion on that, since the contributing guidelines state, that there is no hard limit on line length.

@davidism davidism added this to the 3.0 milestone Apr 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature, or existing feature improvement
Development

Successfully merging a pull request may close this issue.

4 participants