Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Sidekiq 7 and deprecate be_delayed matcher #191

Closed
wspurgin opened this issue Jul 23, 2023 · 0 comments · Fixed by #192
Closed

Support Sidekiq 7 and deprecate be_delayed matcher #191

wspurgin opened this issue Jul 23, 2023 · 0 comments · Fixed by #192
Milestone
v4.0.0

Comments

@wspurgin
Copy link
Owner

wspurgin commented Jul 23, 2023 •
edited

delayed extensions where removed entirely from Sidekiq 7

As such, we should consider that matcher deprecated. However, both the lib (and local tests/dev) should support it so long as we support Sidekiq <7.

Additionally, this should also drop support for Sidekiq <5.
@wspurgin wspurgin mentioned this issue Jul 23, 2023
Merged
@wspurgin wspurgin added this to the v4.0.0 milestone Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
rspec-sidekiq v4.0.0
Status: Done
Milestone
v4.0.0
Development

Successfully merging a pull request may close this issue.

Support Sidekiq 7 wspurgin/rspec-sidekiq
1 participant
@wspurgin