Also publish sdist to PyPI #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #81.
Before #70, we built both the sdist and wheel before uploading to PyPI.
After #70, we built them at the start, uploaded just the wheel as an artifact, then downloaded the wheel for testing, and downloaded the wheel for publishing to PyPI. But no sdist for publishing.
We can fix this by uploading both sdist and wheel as artifact, ensuring we only install the wheel using
--only-binary=:all:, and then for PyPI publishing we also have both files.(Another way would be to rebuild both in the
pypi-releaseinstead of using the artifact.)