Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LCP/ATF Warm up process not blocked on local env #6589

Closed
jeawhanlee opened this issue Apr 24, 2024 · 2 comments · Fixed by #6651
Closed

LCP/ATF Warm up process not blocked on local env #6589

jeawhanlee opened this issue Apr 24, 2024 · 2 comments · Fixed by #6651
Assignees
Labels
effort: [XS] < 1 day of estimated development time lcp priority: medium Issues which are important, but no one will go out of business. type: enhancement Improvements that slightly enhance existing functionality and are fast to implement
Milestone

Comments

@jeawhanlee
Copy link
Contributor

jeawhanlee commented Apr 24, 2024

Is your feature request related to a problem? Please describe.
We are fetching links to send for warm up even on local

Describe the solution you'd like
We need need to check the env (local or not) before sending for warm up.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Acceptance Criteria

  1. If we detect the local environment the whole prewarmup process should be deactivated
  2. The manual visits should still create the LCP/ATF data on local environment
  3. Buttons that are clearing data related to this feature should still be present on local environment
  4. No regressions related to the prewarmup process on life environments
@jeawhanlee jeawhanlee added type: enhancement Improvements that slightly enhance existing functionality and are fast to implement lcp labels Apr 24, 2024
@piotrbak piotrbak added the priority: medium Issues which are important, but no one will go out of business. label May 15, 2024
@piotrbak piotrbak added this to the 3.16.1 milestone May 16, 2024
@jeawhanlee
Copy link
Contributor Author

jeawhanlee commented May 21, 2024

Reproduce the problem ✅

I was able to reproduce this on local

  • Set WP_ROCKET_DEBUG to true
  • Perform any of the actions that triggers the warmup(activate, clear critical images, upgrade to 3.16)
  • See logs

Identify the root cause ✅

We don't bail out here when env is local.

Scope a solution ✅

In Engine\Media\AboveTheFold\WarmUp::Controller
- Add a condition in this method to bail out when env is local.

Update tests.

Estimate the effort ✅

[XS]

@jeawhanlee jeawhanlee added effort: [XS] < 1 day of estimated development time and removed needs: grooming labels May 21, 2024
@Tabrisrp
Copy link
Contributor

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort: [XS] < 1 day of estimated development time lcp priority: medium Issues which are important, but no one will go out of business. type: enhancement Improvements that slightly enhance existing functionality and are fast to implement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants