-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle different error_code coming from RUCSS insted of just 408 #5963
Comments
Hi @mostafa-hisham, I would suggest to take into account Gustav's proposal not to use custom HTTP error codes: Even if it does the job for the feature, it can have bad impact on Ops monitoring (they usually monitor service performances based on standardized error codes) and it would not be a good practice. The goal of the task is to get more details on the errors in the metric system, right? Can the metric system access something else than the "code" field of the response? For instance, we could monitor the "message" field? That could be a good quick win without having to modify the error code mechanism, which will be a bit more tricky (on that topic, which can be dealt with later on, I'll open a dedicated conversation on slack to sort it out). |
Moving issue to "Blocked" while we figure out a solution. |
discussion on-going here |
Following Slack discussion, moving back to "To Grooming" as needs and spec. evolved. Here are the
Several approaches were mentioned and should be investigated during grooming:
|
@MathieuLamiot Scope a solutionI think we need to send back the and on the plugin side, we should change the code to check for the
Estimate the effortEffort |
The solution proposed by @mostafa-hisham is a first step so that we can later on implement error categorization. I created this task as a follow-up/placeholder to actually implement the error categorization if needed. |
I added the proposition into an issue from the RUCSS as I detail technical parts inside it and this issue is one from wpr aka a public one. |
We are going to do what @CrochetFeve0251 said here
and on the plugin side, we should change the code to check for the
Estimate the effortEffort |
RUCSS is going to send different codes instead of only 408 if the page requires a new RUCSS regeneration
issue in RUCSS
407->Protocol error (Target.setAutoAttach): Session closed
408->Navigation timeout
409->Browser couldn't open a new page
We need to change the code to handle the new error codes
wp-rocket/inc/Engine/Optimization/RUCSS/Controller/UsedCSS.php
Line 657 in 536ddfa
The text was updated successfully, but these errors were encountered: