Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move WPCS to v2.2.0 #73

Closed
schlessera opened this issue Nov 11, 2019 · 4 comments
Closed

Move WPCS to v2.2.0 #73

schlessera opened this issue Nov 11, 2019 · 4 comments

Comments

@schlessera
Copy link
Member

The current version of WPCS is not yet compatible with PHP 7.4+.

As soon as the release process for WPCS v2.2.0 is completed, we should move our linting to PHPCS v3.5.2+ and WPCS 2.2.0+ to get PHP 7.4+ linting to work.
@jrfnl
Copy link
Contributor

jrfnl commented Nov 11, 2019

WPCS 2.2.0 has been released ;-)

@jrfnl
Copy link
Contributor

jrfnl commented Nov 11, 2019

While you're at it, it would be a good idea to also update PHPCompatibility where necessary. The latest release - 9.3.3 - came out today as well.

@schlessera
Copy link
Member Author

Thanks for all of your awesome work, @jrfnl ! ❤️

@schlessera
Copy link
Member Author

This was already completed and we're currently requiring v2.3+.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@schlessera @jrfnl