Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workalendar 17.0.0 cal = Ireland Returning Incorrect Date & Holiday Name #763

Open
Paddypy opened this issue Jan 17, 2024 · 0 comments
Open

Comments

@Paddypy
Copy link

Paddypy commented Jan 17, 2024

workalendar version:
Successfully installed convertdate-2.4.0 lunardate-0.2.2 pyluach-2.2.0 pymeeus-0.5.12 workalendar-17.0.0

Tell us which Python version you are using, and your platform.
Python 3.11.7 (tags/v3.11.7:fa7a6f2, Dec 4 2023, 19:24:49) [MSC v.1937 64 bit (AMD64)] on win32

Give us extensive details on the country / area Calendar, the exact date(s) that was (were) computed and the one(s) that should have been the correct result.

from datetime import date
from workalendar.europe import Ireland
cal = Ireland()
cal.holidays(2024)

Incorrect return: (datetime.date(2024, 3, 18), 'Saint Patrick substitute')
Should be: (datetime.date(2024, 2, 05), 'Saint Brigid's Day')

If possible, please provide us a reliable source about the designated country / area calendar, where we could effectively check that we were wrong about a date, and giving us a way to patch our code properly so we can fix the bug.
https://www.gov.ie/pdf/?file=https://assets.gov.ie/216613/acb70756-c004-4cc9-8b4c-3084f8b1c8f5.pdf#page=null

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant