Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When can China's 2024 calendar be updated #761

Open
SLshaolong opened this issue Jan 2, 2024 · 3 comments
Open

When can China's 2024 calendar be updated #761

SLshaolong opened this issue Jan 2, 2024 · 3 comments

Comments

@SLshaolong
Copy link

No description provided.

@onelucksnake
Copy link

可以自己临时改一下"china.py"文件,但我没清楚了解它的逻辑;它的春节与国庆似乎是通过函数计算获取的,所以"hoildays"中定义并没有春节与国庆;而其它的节假日则需要自定义;

另外,它的"hoildays"定义似乎除了定义该日期是否为节假日外,还用于确定该日期是否为工作日,这容易引发一个问题,就是假如节日的日期是通过"holidays"来定义的话,返回的节日实际信息可能有误;

如果你用这个项目只是用于区分"该日期是否为工作日",可以尝试这样定义,注意,我只是猜测这样能"正确区分工作日",仅供参考,实际以官方更新为准:
01
02

@guolei1998
Copy link

图片转json
holidays
2024:
{
'Spring Festival': [(2, 10), (2, 11), (2, 12), (2, 13), (2, 14), (2, 15), (2, 16), (2, 17)],
'Ching Ming Festival':[(4,4),(4,5),(4,6)],
'Labour Day Holiday': [(5, 1), (5, 2), (5, 3), (5,4), (5, 5)],
'Dragon Boat Festival': [(6,8),(6, 9),(6,10)],
'Mid-Autumn Festival': [(9,15),(9,16),(9,17)],
'National Day': [(10, 1), (10, 2), (10, 3), (10, 4), (10, 5), (10, 6), (10, 7)],
'New year': [(1,1)]
}

workdays
2024:{
'Spring Festival Shift': [(2, 4), (2,18)],
'Ching Ming Festival Shift': [(4,7)],
'Labour Day Holiday Shift': [(4,28), (5,11)],
'Dragon Boat Festival Shift':[],
'Mid-Autumn Festival Shift':[(9,14)],
'National Day Shift': [(9,29),(10,12)],
'New year Shift': []
}

@RyoLee
Copy link
Contributor

RyoLee commented Jan 4, 2024

可以自己临时改一下"china.py"文件,但我没清楚了解它的逻辑;它的春节与国庆似乎是通过函数计算获取的,所以"hoildays"中定义并没有春节与国庆;而其它的节假日则需要自定义;

另外,它的"hoildays"定义似乎除了定义该日期是否为节假日外,还用于确定该日期是否为工作日,这容易引发一个问题,就是假如节日的日期是通过"holidays"来定义的话,返回的节日实际信息可能有误;

如果你用这个项目只是用于区分"该日期是否为工作日",可以尝试这样定义,注意,我只是猜测这样能"正确区分工作日",仅供参考,实际以官方更新为准:

01

02

问题出在以前的年三十是放假的,所以大陆的配置里开启了默认生成年三十,这里需要改开关项,然后把历史数据里的年份手动补配置成假期,ref的pr没处理这个问题,所以ut case看起来比较奇怪

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants