Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Personalize Home Tab: Does not support RTL languages #19256

Closed
zwarm opened this issue Sep 25, 2023 · 6 comments · Fixed by #20785
Closed

Personalize Home Tab: Does not support RTL languages #19256

zwarm opened this issue Sep 25, 2023 · 6 comments · Fixed by #20785
Assignees
@AjeshRPai
Labels
[Type] Bug [Type] Task
Milestone
Future

Comments

@zwarm
Copy link
Contributor

zwarm commented Sep 25, 2023

Expected behavior

Expect the view to support RTL languages

Actual behavior

The view format does not support RTL languages

Steps to reproduce the behavior

  • Navigate to Me tab > App Settings > Interface Language
  • Select a RTL language (Hebrew is a good choice)
  • Navigate back to My Site tab
  • Scroll down to the Personalize your home card and tap on it
  • The Personalize home tab is not shown in RTL
Tested on [device], Android [version], JPAndroid / WPAndroid [version]

Pixel 5, Android 13, JPAndroid 23.3-rc-1
@zwarm zwarm added this to the 23.4 milestone Sep 25, 2023
@peril-wordpress-mobile
Copy link

Fails
🚫 Please add a feature label to this issue. e.g. 'Stats'

Generated by 🚫 dangerJS

1 similar comment
@peril-wordpress-mobile
Copy link

Fails
🚫 Please add a feature label to this issue. e.g. 'Stats'

Generated by 🚫 dangerJS

@oguzkocer oguzkocer modified the milestones: 23.4, 23.5 Oct 2, 2023
@zwarm
Copy link
Contributor Author

zwarm commented Oct 4, 2023

Will be addressed in PR #19151

@oguzkocer oguzkocer modified the milestones: 23.5, 23.6 Oct 16, 2023
@oguzkocer oguzkocer modified the milestones: 23.6, 23.7 Oct 30, 2023
@oguzkocer oguzkocer modified the milestones: 23.7, 23.8 Nov 13, 2023
@spencertransier spencertransier modified the milestones: 23.8, 23.9 Nov 27, 2023
@oguzkocer oguzkocer modified the milestones: 23.9, 24.0 Dec 11, 2023
@oguzkocer oguzkocer modified the milestones: 24.0, 24.1 Jan 9, 2024
@AjeshRPai AjeshRPai modified the milestones: 24.1, Future Jan 12, 2024
@mrfoxtalbot
Copy link

@zwarm. @ravishanker. has this issue now been fixed? Can we mark it as solved? Thank you!

@ravishanker
Copy link
Contributor

@mrfoxtalbot - Doesn't look like it is fixed.

@zwarm, @AjeshRPai That particular screen is not showing any translations, not just RTL languages even though the translation strings exist!

@AjeshRPai AjeshRPai mentioned this issue May 9, 2024
Merged
12 tasks
@AjeshRPai
Copy link
Contributor

AjeshRPai commented May 9, 2024 •
edited

Hey @ravishanker
I have raised a PR - #20785 to fix this.

Just an FYI. This might be an issue in a lot of screens which we have implemented using Compose. Might need to wrap those compose UI with LocaleAwareComposable to fix the issue in those screens.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AjeshRPai AjeshRPai

Labels
[Type] Bug [Type] Task
Projects
None yet
Milestone
Future
Development

Successfully merging a pull request may close this issue.

Fixes: Personalization screen not respecting translation or RTL wordpress-mobile/WordPress-Android
6 participants
@zwarm @oguzkocer @ravishanker @mrfoxtalbot @AjeshRPai @spencertransier