Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency Updates - Main Batch - AndroidX Jetpack #17564

Closed
2 tasks done
ParaskP7 opened this issue Nov 29, 2022 · 5 comments
Closed
2 tasks done

Dependency Updates - Main Batch - AndroidX Jetpack #17564

ParaskP7 opened this issue Nov 29, 2022 · 5 comments

Comments

@ParaskP7
Copy link
Contributor

ParaskP7 commented Nov 29, 2022

Parent #17551

This issue is about updating all Main - AndroidX Jetpack related dependencies for the whole project.

This Main - AndroidX Jetpack batch contains the following 2 dependencies:

@peril-wordpress-mobile
Copy link

Fails
🚫

Please add a type label to this issue. e.g. '[Type] Enhancement'

Generated by 🚫 dangerJS

2 similar comments
@peril-wordpress-mobile
Copy link

Fails
🚫

Please add a type label to this issue. e.g. '[Type] Enhancement'

Generated by 🚫 dangerJS

@peril-wordpress-mobile
Copy link

Fails
🚫

Please add a type label to this issue. e.g. '[Type] Enhancement'

Generated by 🚫 dangerJS

@ParaskP7 ParaskP7 mentioned this issue Nov 29, 2022
50 tasks
@ParaskP7
Copy link
Contributor Author

❓ These androidxRoomVersion related dependencies were added due to the failing Android tests. I recommend checking that out again and see is this set of dependencies are really necessary, maybe that set of room dependencies can be complete removed.

Also, check the kapt usage on androidx.room:room-compiler, while everything else in on androidTestImplementation. The kapt should probably be updated to androidTestKapt. 🤔

@ParaskP7
Copy link
Contributor Author

ParaskP7 commented Feb 2, 2023

❓ These androidxRoomVersion related dependencies were added due to the failing Android tests. I recommend checking that out again and see is this set of dependencies are really necessary, maybe that set of room dependencies can be complete removed.

FYI: Room got removed as part of this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant