Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WooCommerce ESLint plugin should be upgraded to work with ESLint >= 8.0.0 #32153

Closed
joshuatf opened this issue Feb 23, 2022 · 2 comments
Closed

WooCommerce ESLint plugin should be upgraded to work with ESLint >= 8.0.0 #32153

joshuatf opened this issue Feb 23, 2022 · 2 comments
Assignees
@chihsuan
Labels
plugin: woocommerce Issues related to the WooCommerce Core plugin. type: technical debt This issue/PR represents/solves the technical debt of the project.

Comments

@joshuatf
Copy link
Contributor

Describe the bug

Consumers of @woocommerce/eslint-plugin using ESLint 8 or greater will result in errors since plugin:testing-library/recommended has been removed.

To fix this we can:

  • Bump eslint to 8.0.0 or greater
  • Bump eslint-plugin-testing-library to 5.0.0 or greater
  • Update plugin:testing-library/recommended to plugin:testing-library/react in packages/eslint-plugin/configs/react-testing-library.js

For anyone using @woocommerce/eslint-plugin in the meantime, you can downgrade to both eslint@^7.32.0 and eslint-plugin-testing-library^3.10.2 to keep this ruleset.

To Reproduce

  1. In a new repo, clone @woocommerce/eslint-plugin
  2. Install eslint 8 or greater
  3. Run eslint from the command line
  4. Note the error
@rjchow rjchow added the type: technical debt This issue/PR represents/solves the technical debt of the project. label Feb 24, 2022
@chihsuan chihsuan self-assigned this Mar 18, 2022
@chihsuan chihsuan mentioned this issue Mar 18, 2022
Merged
@woocommercebot woocommercebot transferred this issue from woocommerce/woocommerce-admin Mar 19, 2022
@woocommercebot woocommercebot added plugin: woocommerce Issues related to the WooCommerce Core plugin. focus: react admin labels Mar 19, 2022
@github-actions github-actions bot added the status: awaiting triage This is a newly created issue waiting for triage. label Mar 19, 2022
@chihsuan chihsuan removed the status: awaiting triage This is a newly created issue waiting for triage. label Mar 21, 2022
@adrianduffell
Copy link
Contributor

@chihsuan can this now be closed by woocommerce/woocommerce-admin#8475?

@chihsuan
Copy link
Member

@adrianduffell Yes. 😄 thanks for the ping!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chihsuan chihsuan

Labels
plugin: woocommerce Issues related to the WooCommerce Core plugin. type: technical debt This issue/PR represents/solves the technical debt of the project.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@chihsuan @adrianduffell @joshuatf @rjchow @woocommercebot