Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update @woocommerce/eslint-plugin to the latest 1.3 #2270

Closed
asumaran opened this issue Jan 7, 2022 · 2 comments 路 Fixed by #2819
Closed

Update @woocommerce/eslint-plugin to the latest 1.3 #2270

asumaran opened this issue Jan 7, 2022 · 2 comments 路 Fixed by #2819
Labels
good first issue The issue is a good candidate for the first community contribution/for a newcomer to the team. status: on hold The issue is currently not prioritized.

Comments

@asumaran
Copy link
Contributor

asumaran commented Jan 7, 2022

Hi @asumaran @ricardo , sorry for the late reply! I am good with the // eslint-disable-next-line as well. 馃憤

I think the idea was to prevent the use of listener on window document globals inside hooks and react components. It looks like the no global rule is removed in WordPress/gutenberg#34528. Maybe we can try updating our @woocommerce/eslint-plugin to the latest 1.3?

Originally posted by @harriswong in #2252 (comment)

@asumaran asumaran changed the title Updating @woocommerce/eslint-plugin to the latest 1.3 Update @woocommerce/eslint-plugin to the latest 1.3 Jan 7, 2022
@asumaran asumaran added the good first issue The issue is a good candidate for the first community contribution/for a newcomer to the team. label Jan 7, 2022
@asumaran asumaran self-assigned this Jan 11, 2022
@asumaran
Copy link
Contributor Author

The idea to update the @woocommerce/eslint-plugin dependency in our project was to remove the "no global event" rule that was added recently. The PR that removes it has been merged but has not been included in the @wordpress/eslint-plugin@8.x.x package.

Unfortunately, @woocommerce/eslint-plugin is still using the 8.x.x series of the @wordpress/eslint-plugin package as a dependency. The rule is still present in the 8.0.2 version of the @wordpress/eslint-plugin.

We need to wether update @woocommerce/eslint-plugin to use the latest @wordpress/eslint-plugin or merge WordPress/gutenberg#34528 into the 8.x.x version of the @wordpress/eslint-plugin.

@asumaran asumaran added the status: on hold The issue is currently not prioritized. label Jan 12, 2022
@asumaran asumaran removed their assignment Jan 12, 2022
@asumaran
Copy link
Contributor Author

asumaran commented Jun 26, 2023

@woocommerce/eslint-plugin updated @wordpress/eslint-plugin from v8.0.0 to v11.0.0 in woocommerce/woocommerce-admin#8475 but a new release of the 1.3.x branch of the @woocommerce/eslint-plugin extension wasn't released up until today.

1.3.x seems abandoned so probably we should update @woocommerce/eslint-plugin to its latest version instead (v2.2.0)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue The issue is a good candidate for the first community contribution/for a newcomer to the team. status: on hold The issue is currently not prioritized.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant