Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

State dropdown not showing exact match. WA = Delaware instead of Washington #20575

Closed
ryanr14 opened this issue Jun 19, 2018 · 5 comments · May be fixed by woocommerce/selectWoo#21
Closed

State dropdown not showing exact match. WA = Delaware instead of Washington #20575

ryanr14 opened this issue Jun 19, 2018 · 5 comments · May be fixed by woocommerce/selectWoo#21
Labels
status: won't fix The issue won’t be fixed. type: enhancement The issue is a request for an enhancement.

Comments

@ryanr14
Copy link
Member

ryanr14 commented Jun 19, 2018

Describe the bug
If you head to checkout and start typing in a state like Washington, or use the abbreviation WA, you won't get Washington first. The same for other states I quickly tested, IN or MA won't show the exact matches first either.

To Reproduce
Steps to reproduce the behavior:

  1. Go to checkout
  2. Open the state field.
  3. Type in something like WA, which you would think would show Washington first
  4. See error as Delaware comes up first, among others before Washington shows up.

Screenshots
https://cld.wthms.co/ztfz83

Expected behavior
If you typed in WA you'd figure the state that exactly matches the first two letters would show up. The same happens for others like IN or MA.
@mikejolley mikejolley added the type: enhancement The issue is a request for an enhancement. label Jun 19, 2018
@mikejolley mikejolley added this to the 3.5.0 milestone Jun 19, 2018
@nishitlangaliya nishitlangaliya mentioned this issue Jun 22, 2018
Closed
6 tasks
@nishitlangaliya
Copy link
Contributor

PR done #20605

@mikejolley
Copy link
Member

See woocommerce/selectWoo#20 cc @claudiulodro Maybe we can get that update into 3.5?

@claudiulodro claudiulodro reopened this Jul 5, 2018
@claudiulodro
Copy link
Contributor

See my comment on woocommerce/selectWoo#20. We are going to need to make some sort of prioritization algorithm for the dropdown where things that start with the search phrase are higher up in the list than things that contain the search phrase in the middle.

@nishitlangaliya
Copy link
Contributor

@claudiulodro ,

Thanks for review my PR and your valuable suggestions.

Thanks.

@peterfabian peterfabian mentioned this issue Jul 12, 2018
Open
3 tasks
@grokdesigns grokdesigns mentioned this issue Jul 16, 2018
Closed
@claudiulodro claudiulodro removed this from the 3.5.0 milestone Jul 23, 2018
@mikejolley
Copy link
Member

I'm closing this as it's part of the SelectWoo library.

I think there could be an argument for either way. Ranking by the entered text is one way, but alphabetically like now is another. As you enter more text the matched options are reduced anyhow.

When checkout is redesigned I expect we'll phase out select woo entirely but we'll see :) #needsdesign

@mikejolley mikejolley added the status: won't fix The issue won’t be fixed. label Feb 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: won't fix The issue won’t be fixed. type: enhancement The issue is a request for an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Changed ordering of matched strings in the dropdown--start of string … woocommerce/selectWoo
5 participants
@mikejolley @ryanr14 @peterfabian @claudiulodro @nishitlangaliya