customTextRenderer not working correctly in v6

[paescuj]

Before you start - checklist

• I followed instructions in documentation written for my React-PDF version
• I have checked if this bug is not already reported
• I have checked if an issue is not listed in Known issues
• If I have a problem with PDF rendering, I checked if my PDF renders properly in PDF.js demo

Description

The customTextRenderer doesn't seem to work correctly anymore in v6.

If a customTextRenderer is defined (even with the example provided under Page -> Props) the text elements are wrongly positioned and there are a lot elements with the content undefined:

<span style="left: 101.687px; top: 100.54px; font-size: 2.16834px; font-family: sans-serif;" role="presentation" dir="ltr">undefined</span>

If the customTextRenderer is removed, everything works as expected and the text elements are correctly positioned.

Steps to reproduce

1. Configure custom rendered:

<Page
  customTextRenderer={
    ({ str, itemIndex }) => {
      return `<mark>${str}</mark>`;
    }
  }
  ...
/>

2. Check page and inspect elements

Expected behavior

Text elements via custom rendered should be positioned correctly and not include undefined values

Actual behavior

Text elements are wrongly positioned (clearly visible when using <mark>) and contains undefined values

Additional information

No response

Environment

• Browser (if applicable): Firefox 106.0.5
• React-PDF version: 6.0.2
• React version: 18.2.0
• Webpack version (if applicable): -

[wojtekmaj]

"not working" is a bit of an overstatement, but yes, the example provided wasn't very good and lacked a null check which was not necessary in React before. Fixed that. :)

[paescuj]

"not working" is a bit of an overstatement [...]

I agree and I'd like to apologize for the way I expressed myself!

[...] but yes, the example provided wasn't very good and lacked a null check which was not necessary in React before. Fixed that. :)

Thank you for your quick response and also thank you for maintaining this awesome package ❤️

Unfortunately, I still think that the customTextRenderer functionality is not working "correctly" in v6.
I just submitted #1152 to make this better visible.

If the custom text renderer is activated, there are a lot of these elements with the value undefined:

If the the custom text renderer is disabled, no such elements will show up:

You will also notice that without the custom text renderer, the text is perfectly selectable (whole line):

Whereas with the custom text renderer, it is not (this used to work pre-v6):

[wojtekmaj]

Yup, that is a valid bug - thank you for noticing this!