Action: Replace deprecated set-output command #668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henryiii
reviewed
Oct 28, 2022
airtower-luna
force-pushed
the
replace-set-output
branch
from
42c8778
to
13cd7df
Compare
henryiii
approved these changes
Oct 31, 2022
DiddiLeija
approved these changes
Oct 31, 2022
|
This looks good, just needs a conflict resolution because I merged #667 in before this one 👍🏻 |
The set-output workflow command has been deprecated [1] and replaced with writing to an environment file. Update .github/action_helper.py to use the new file. [1] https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Changing .github/action_helper.py changes the behavior of the action even if action.yml doesn't change. This makes tests run anyway.
airtower-luna
force-pushed
the
replace-set-output
branch
from
13cd7df
to
01db28d
Compare
|
Rebased on |
|
Does anyone have an idea what went wrong in the "macos-latest, 3.8" build? The log looks to me like a |
|
Looks like a spurious error to me, I'll re-run and see what happens |
|
Okay, well now it's 3.11 apparently! |
|
5th time's the charm it seems! |
|
Thanks @airtower-luna 🎉 |
airtower-luna
added a commit
to airtower-luna/mpvasync
that referenced
this pull request
Oct 31, 2022
Including switching wntrblm/nox to upstream after my patch has been merged [1]. [1] wntrblm/nox#668
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
set-outputworkflow command has been deprecated and replaced with writing to an environment file. Update.github/action_helper.pyto use the new file.