Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Point action docs to 2022.8.7 not latest #664

Merged
merged 2 commits into from Oct 22, 2022
Merged

Conversation

FollowTheProcess
Copy link
Collaborator

@FollowTheProcess FollowTheProcess commented Oct 20, 2022

Fixes a mention in the docs to @latest which doesn't actually refer to a valid tag, my bad for not spotting! 馃憤馃徎 Thanks @henryiii

Copy link
Collaborator

@DiddiLeija DiddiLeija left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you both @FollowTheProcess and @henryiii!

Small question: Is @main possible, instead of @latest? If not, I'm ok with merging this 馃憤

@DiddiLeija
Copy link
Collaborator

Small question: Is @main possible, instead of @latest? If not, I'm ok with merging this 馃憤

Ahh sorry, I didn't read #662 yet :/

@henryiii
Copy link
Collaborator

@main is fine too, you can put any branch or tag name there.

@DiddiLeija
Copy link
Collaborator

Ok. I'm personally more comfortable with @main, but a tag is fine too (however, we'll have to update that tag frequently).

@FollowTheProcess
Copy link
Collaborator Author

FollowTheProcess commented Oct 20, 2022

A specific tag is always preferable IMO, it means a user of the action is always getting an exact version rather than whatever is on the main branch (which may, although unlikely, break). What do we think?

If we need to keep it up to date with new versions there's things like bump2version that can find and replace, or we just leave it with a comment that says e.g "any tagged version will work here"

@DiddiLeija
Copy link
Collaborator

If we need to keep it up to date with new versions there's things like bump2version that can find and replace, or we just leave it with a comment that says e.g "any tagged version will work here"

That would resolve my concerns of using a specific tag!

@FollowTheProcess FollowTheProcess merged commit 801455b into main Oct 22, 2022
@FollowTheProcess FollowTheProcess deleted the fix/action-docs branch October 22, 2022 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

None yet

3 participants