chore: some refurb suggestions and cleanup old Python 2-3.6 stuff #657
Conversation
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
| @@ -14,33 +14,8 @@ | |||
|
|
|||
| from __future__ import annotations | |||
|
|
|||
| __all__ = ["TYPE_CHECKING", "ClassVar", "NoReturn", "Python"] | |||
There was a problem hiding this comment.
TYPE_CHECKING was added in 3.5.2, ClassVar in 3.5.3, and NoReturn in 3.5.4/3.6.2. All are now always present.
|
Looks great 👍🏻 Side note: what's reverb? The only thing I can find on PyPI is a regex library |
henryiii
changed the title
|
Ahh, mistyped. Refurb. |
|
It's a linter built using some of the mypy internals. So I'm therory it can do a few checks that other linters would have trouble getting. It's focused on "modernizing", a bit like pyupgrade, but willing to make suggestions that pyupgrade would not implement (like try/except pass for contextlib.suppress - pyupgrade can't add an import). I've found some of the suggestions helpful, and it's really easy to |
|
Ahh nice, I'll check that out! |
I tried running
refurb, and it had a few good suggestions, I also found some old Python workarounds (for 3.6.1 and before) that could be cleaned up.