Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix example in docs using session.posargs #653

Merged
merged 1 commit into from Oct 7, 2022
Merged

Fix example in docs using session.posargs #653

merged 1 commit into from Oct 7, 2022

Conversation

paw-lu
Copy link
Contributor

@paw-lu paw-lu commented Sep 23, 2022 •
edited

Current example feeds session.posargs directly into session.run. I don't think this works—as session.posargs is a list. Added an unpacking argument * as a quick fix.

Thanks for the great work here!

FollowTheProcess
FollowTheProcess approved these changes Oct 7, 2022
View reviewed changes
Copy link
Collaborator

@FollowTheProcess FollowTheProcess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @paw-lu nice catch! Thanks 🎉

@FollowTheProcess FollowTheProcess merged commit 49f2de0 into wntrblm:main Oct 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FollowTheProcess FollowTheProcess FollowTheProcess approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@paw-lu @FollowTheProcess