Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support NextJS + Stylable #1744

Closed
tomrav opened this issue Apr 7, 2021 · 0 comments · Fixed by #1720
Closed

Support NextJS + Stylable #1744

tomrav opened this issue Apr 7, 2021 · 0 comments · Fixed by #1720
Labels
bug Unexpected behavior or exception integration Bundler, test-runner and node

Comments

@tomrav
Copy link
Collaborator

tomrav commented Apr 7, 2021

This issue is a continuation of #1710, as it appears that we still have issues with making Stylable and NextJS work together.

I believe that currently most of our problems stem from the fact that NextJS bundle their own version of webpack (v4 or v5, starting here vercel/next.js#20598) inline in their code. This means that any plugin that imports anything from webpack (like ours) would fail on instanceof checks inside webpack due to two different versions/instances running.

We are in the process of making our webpack plugin import only types from webpack and not require on any actual runtime imports, instead bringing the required entities from webpack itself (see #1720).

@tomrav tomrav added bug Unexpected behavior or exception integration Bundler, test-runner and node labels Apr 7, 2021
@AviVahl AviVahl linked a pull request Apr 7, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Unexpected behavior or exception integration Bundler, test-runner and node
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant