Skip to content

fix: allow CORS requests #121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 30, 2022
Merged

fix: allow CORS requests #121

merged 1 commit into from
Sep 30, 2022

Conversation

rchl
Copy link
Contributor

@rchl rchl commented Aug 3, 2022

When testing in a browser environment, if the request is "non-trivial", the browser will trigger a preflight request first and expect the server to allow it.

The rrweb makes "non-trivial" requests as it uses a mime type that per CORS rules requires a preflight request.

Resolves #105

@zivl
Copy link
Owner

zivl commented Sep 30, 2022

@rchl its a great feature to add!
much of appreciation 🥇

@zivl zivl merged commit 29720b5 into zivl:master Sep 30, 2022
@zivl
Copy link
Owner

zivl commented Sep 30, 2022

released in sentry-testkit@4.1.0

@rchl rchl deleted the fix/cors branch September 30, 2022 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for sending the CORS header from localServer
2 participants