Skip to content
This repository has been archived by the owner on Jun 6, 2023. It is now read-only.

We missed breaking change in Axios error handling #231

Closed
everhardt opened this issue Jun 3, 2022 · 1 comment 路 Fixed by #232
Closed

We missed breaking change in Axios error handling #231

everhardt opened this issue Jun 3, 2022 · 1 comment 路 Fixed by #232
Assignees
@everhardt
Labels
bug Something isn't working released on @main

Comments

@everhardt
Copy link
Collaborator

馃悰 Bug report

What is wrong

Axios introduced a breaking change in error handling in v0.27.0 (see axios/axios#3645 for details). Beware: until v1 they mark breaking changes by upping the minor version.

Steps to reproduce

  • do not start platform
  • start platform-client

You would expect a CommsRequestError, which would be shown in the client as:
The server cannot be reached. Check status.withthegrid.com to identify whether this is caused by withthegrid or your browser/ connection. Instead, we see The requested resource cannot be found..
@everhardt everhardt added the bug Something isn't working label Jun 3, 2022
@everhardt everhardt self-assigned this Jun 3, 2022
everhardt added a commit that referenced this issue Jun 3, 2022
@everhardt
fix: axios error
ea500c2 
fixes #231
@everhardt everhardt mentioned this issue Jun 3, 2022
Merged
Arinono pushed a commit that referenced this issue Jun 3, 2022
@everhardt
fix: axios error (#232)
97ace04 
fixes #231
github-actions bot pushed a commit that referenced this issue Jun 3, 2022
@semantic-release-bot
chore(release): 17.42.16 [skip ci]
977be44 
### [17.42.16](v17.42.15...v17.42.16) (2022-06-03)

### Bug Fixes

* axios error ([#232](#232)) ([97ace04](97ace04)), closes [#231](#231)
@github-actions
Copy link

github-actions bot commented Jun 3, 2022

馃帀 This issue has been resolved in version 17.42.16 馃帀

The release is available on GitHub release

Your semantic-release bot 馃摝馃殌

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@everhardt everhardt

Labels
bug Something isn't working released on @main
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: axios error withthegrid/platform-sdk
1 participant
@everhardt