Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃悰 BUG: Dev Server not resetting automatically #3263

Closed
1 task
Eloi-Perez opened this issue May 3, 2022 · 8 comments
Closed
1 task

馃悰 BUG: Dev Server not resetting automatically #3263

Eloi-Perez opened this issue May 3, 2022 · 8 comments
Assignees
Labels
- P5: urgent Fix build-breaking bugs affecting most users, should be released ASAP (priority) ecosystem: upstream Upstream package has issue

Comments

@Eloi-Perez
Copy link
Contributor

Eloi-Perez commented May 3, 2022

What version of astro are you using?

1.0.0-beta.20

Are you using an SSR adapter? If so, which one?

None

What package manager are you using?

npm

What operating system are you using?

Windows 10 21H2 - PowerShell 7.2.3

Describe the Bug

Using the development server astro dev, when I do a mistake on my code giving me as a result a "500: Internal Error", once I fix the error the server is suppose to reset and show me the website if everything is fine with my code, but every time, I have to reset the server manually.

Link to Minimal Reproducible Example

Can't reproduce it online

Participation

  • I am willing to submit a pull request for this issue.
@github-actions github-actions bot added this to Needs Triage in 馃悰 Bug Tracker May 3, 2022
@Eloi-Perez Eloi-Perez changed the title 馃悰 BUG: 馃悰 BUG: Dev Server not resetting automatically May 3, 2022
@Eloi-Perez
Copy link
Contributor Author

Eloi-Perez commented May 3, 2022

I also just tried the Dev Server with WSL2 (Ubuntu) and I have exactly the same problem.

@Jutanium
Copy link
Contributor

Jutanium commented May 3, 2022

See #3228 and others, this is important

@matthewp matthewp moved this from Needs Triage to Accepted in 馃悰 Bug Tracker May 4, 2022
@matthewp matthewp self-assigned this May 4, 2022
@Jutanium
Copy link
Contributor

Jutanium commented May 4, 2022

Related issues - I'm not sure which of these have the same root cause, but in all cases we can improve the end-user situation with error boundaries
#3196
#3180
#2921

Panic mode - here there are two problems at hand: one is that there is a bug, and the other is that the compiler shifts into a very unfriendly panic mode:
withastro/compiler#390
#3253

We've actually had that named slot issue open for more than two weeks: withastro/compiler#388

@matthewp
Copy link
Contributor

matthewp commented May 6, 2022

Upstream PR needs merging before we can fix this one: vitejs/vite#8052

@matthewp
Copy link
Contributor

matthewp commented May 9, 2022

Upstream was merged, waiting on a release.

@matthewp matthewp added - P5: urgent Fix build-breaking bugs affecting most users, should be released ASAP (priority) s1-small and removed bb:investigate labels May 10, 2022
@matthewp
Copy link
Contributor

After Vite 2.9.9 is merged we can fix this. We need to update the Astro plugin to set import.meta.hot here:

// // import.meta.hot.accept(["${id}", "${Array.from(deps).join('","')}"], (...mods) => mods);
. Doing so will cause it to correctly invalidate .astro modules when dependencies go from broken to fixed.

@Jutanium
Copy link
Contributor

Thanks! Will this also fix the issue with Astro.glob (i.e., when you put an invalid string in there, and then fix it, the dev server should be good to go)

@Eloi-Perez
Copy link
Contributor Author

It seems to be fixed now. Thank you!

馃悰 Bug Tracker automation moved this from Accepted to Done May 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
- P5: urgent Fix build-breaking bugs affecting most users, should be released ASAP (priority) ecosystem: upstream Upstream package has issue
Projects
No open projects
Development

No branches or pull requests

4 participants