Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn instead of raising a ValueError when some keys in the 'force' dict do not match the table's column_names #747

Conversation

lcorbasson
Copy link
Contributor

Rationale:

  • The force argument may be used in a generic way to force types for column names in several tables, while these column names do not exist in each of the tables.
  • The current behaviour involves loading each table twice to first check which column_names are present; this is not efficient.
  • Changing this behaviour to a simple warning doesn't add any risks or side effects to the current use case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants