Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Python versions, test on more platforms and fix Travis CI issues #734

Merged
merged 103 commits into from Mar 31, 2020
Merged

Update Python versions, test on more platforms and fix Travis CI issues #734

merged 103 commits into from Mar 31, 2020

Conversation

lcorbasson
Copy link
Contributor

@lcorbasson lcorbasson commented Feb 3, 2020 •
edited

This PR fixes Travis CI issues by:

  • dropping support for Python 3.4 (EOL and unsupported by the current lxml),
  • adding ICU / PyICU to the various Travis CI builds,
  • extending testing to:
    • Python 3.7 and 3.8,
    • various versions of PyPy3,
    • other versions of PyPy2,
    • MacOS X and Windows (but allowing tests to fail there),
  • fixes issues with bad detection of TRAVIS_PYTHON_VERSION and segmentation faults of nosetests on PyPy3,
  • fixes agate.Number().cast(u'👍') (or any other Unicode char) on PyPy3,
  • fixes agate.Table.from_json() on platforms where UTF-8 is not the default encoding (e.g. Travis CI's Windows build, which uses CP1252).

It also ensures files are closed even if an error occurs in:

  • agate.Table.from_csv(),
  • agate.Table.from_fixed(),
  • agate.Table.from_json().

And it takes into account the user's locale when running tests displaying numbers with decimal or grouping separators.

It is meant as a replacement for PR #731 and #732, and fixes #694.

lcorbasson and others added 30 commits January 8, 2020 15:23
@lcorbasson
The new lxml version requires python3>=3.5
f12f3f5
@lcorbasson
Test with newer Python3 versions
c4fdc8f
@lcorbasson
Drop support for py3.4
d2e27e7
@lcorbasson
Fix pypy versions
e2ffc17
@lcorbasson
Use the pypy aliases to always match the default release for Travis CI
a10ea70
@lcorbasson
Revert to non-aliased versions to avoid getting bugs from a beta version
53a5ed6
@lcorbasson
Fix UserWarning: __builtin__.type size changed, may indicate binary i…
b5f2faf 
…ncompatibility
@lcorbasson
upgrade sqlite in travis test containers
d3fc10d 
travis-ci/travis-ci#7873
@lcorbasson
Update tox ; correct pypy versions
a5f8269
@lcorbasson
Try to add new environments
5a4f7d8
@lcorbasson
Update Python versions
98b621f
@lcorbasson
Correct Linux builds; allow failure on OSes other than Linux
1250066
@lcorbasson
Merge jobs and matrix
dc65b15
@lcorbasson
Fix YAML
54235c7
@lcorbasson
Move recent versions to the top -- making the most recent version the…
f076fed 
… default one
@lcorbasson
Try a simplification for the default Linux OS
930631f
@lcorbasson
Try to make it even more simple
78bb2e6
@lcorbasson
Fix the macOS lxml build
31df35c
@lcorbasson
Names are not necessary
047e1a1
@lcorbasson
Fix the Windows build; trace Python versions better
7a4ad8b
@lcorbasson
Add --user to pip install
0d10e25
@lcorbasson
Remove --user from pip install
90237c8
@lcorbasson
Add a virtualenv on macOS, and some caching
45823ef
@lcorbasson
Add lxml for win64 from a pre-built wheel
4b80d0b
@lcorbasson
Make Python 3 the default (fixes build issues on Win64 and macOS, too…
be17473 
…, where TRAVIS_PYTHON_VERSION is not defined)
@lcorbasson
Give it a try without specifying the lxml wheel
6839070
@lcorbasson
Fix YAML typos
d1b3886
@lcorbasson
Correct TRAVIS_PYTHON_VERSION for pypy
86e1a85
@lcorbasson
Fix YAML typos for allow_failures
dd1e3cc
@lcorbasson
Investigate on failing on tests on PyPy3
480f798
lcorbasson and others added 28 commits February 5, 2020 19:57
@lcorbasson
Allow failures on all PyPy builds
f71bc98
@lcorbasson
Unicode delimiter test not needed anymore
f1563b3
@lcorbasson
Correct envlist
3b28c68
@lcorbasson
try updating PKG_CONFIG_PATH on macOS
e5e0d94
@lcorbasson
Try running uconv -V to get the ICU version
64669bb
@lcorbasson
Download the ICU DLLs for Windows
e69bcf7
@lcorbasson
Windows: correct ICU path, silence wget
c5733d1
@lcorbasson
Windows: Add ICU to various config vars
1755f2b
@lcorbasson
List available locales on Windows and macOS
f907e41
@lcorbasson
Add ICU libraries file names
2b3935b
@lcorbasson
Portability: short options for locale
c24f957
@lcorbasson
Test Korean date formats on macOS
7832509
@lcorbasson
Win64: Correct flags
fee7b09
@lcorbasson
Add $PWD to LFLAGS
571763f
@lcorbasson
Adapt date parameters to macOS
ee0edf7
@lcorbasson
Windows: try vcpkg
0b81a8e
@lcorbasson
Disable vcpkg metrics
7aaa0c9
@lcorbasson
Try to find vcpkg files
730b9f7
@lcorbasson
Windows: update env vars with the paths of the ICU vcpkg package
4f85d18
@lcorbasson
Adjust am/pm tests for platforms that do not localize them
80d9516
@lcorbasson
test_cast_format_locale(): Better position for try/except, and raise …
a703957 
…AssertionError if invalid
@lcorbasson
Get correct PyICU settings on macOS
58d7b02
@lcorbasson
Add ICU_VERSION to macOS build
fe73ca7
@lcorbasson
Remove date samples
441bc65
@lcorbasson
Optimize nosetests
767946b
@lcorbasson
Run each test in its own process on PyPy*
c17fe89 
The previous commit was sufficient for PyPy3 and to fix tests.test_py3.TestSniffer.test_sniffer() where csv_py3.Sniffer().sniff(contents).__dict__ on some Python versions where it was empty. This commit tries to fix segfault issues on PyPy by breaking the tests in yet more processes.
@lcorbasson
fix typos
bf694ad
@lcorbasson
Fix typo
f070b71
@jpmckinney jpmckinney merged commit e04cfe9 into wireservice:master Mar 31, 2020
@jpmckinney jpmckinney mentioned this pull request Mar 31, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpmckinney jpmckinney jpmckinney left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Should we ditch pypy?
2 participants
@lcorbasson @jpmckinney