Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow localization of datetimes #730

Merged
merged 6 commits into from Feb 3, 2020
Merged

Allow localization of datetimes #730

merged 6 commits into from Feb 3, 2020

Conversation

lcorbasson
Copy link
Contributor

@lcorbasson lcorbasson commented Jan 7, 2020 •
edited

This PR allows to read localized dates and datetimes, with or without a date(time) format.

jpmckinney
jpmckinney reviewed Feb 3, 2020
View reviewed changes
Copy link
Member

@jpmckinney jpmckinney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Can you add an entry to CHANGELOG.rst? Feel free to add yourself to AUTHORS.rst as well.

tests/test_data_types.py Show resolved Hide resolved
@jpmckinney jpmckinney merged commit 447de14 into wireservice:master Feb 3, 2020
@jpmckinney
Copy link
Member

Nevermind – I'll make those updates. Thanks!

@lcorbasson lcorbasson deleted the localized_datetimes branch February 5, 2020 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpmckinney jpmckinney jpmckinney left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lcorbasson @jpmckinney