Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removes maven dir in output shadow jar #1993

Merged
merged 2 commits into from Oct 21, 2022

Conversation

krageon
Copy link
Contributor

@krageon krageon commented Oct 18, 2022

I think this is okay as I cannot find a reference to it either in the code or in the dependencies of any of the build stages (transitive or otherwise).

…s is okay as I cannot find a reference to it either in the code or in the dependencies of any of the build stages (transient or otherwise).
@krageon
Copy link
Contributor Author

krageon commented Oct 18, 2022

This fixes #1990 . It's been a few years since I did java things so my tooling fu is admittedly a little weak. If I missed something I'd like to figure out what that is. Thanks :)

@tomakehurst
Copy link
Member

I'm wondering if we can just cut the whole META-INF/maven directory. I'm not sure it's serving any purpose, even for the dependencies that are actually present.

@krageon
Copy link
Contributor Author

krageon commented Oct 19, 2022

This was my initial resolution, but I figured I'd leave the changes to the minimum required to get things resolved. I'm perfectly willing to remove the whole thing, so I will do that after I eat. An hour or so.

@krageon krageon changed the title removes commons-text from maven dir in output shadow jar removes maven dir in output shadow jar Oct 19, 2022
@krageon
Copy link
Contributor Author

krageon commented Oct 19, 2022

@tomakehurst all done chief

@krageon
Copy link
Contributor Author

krageon commented Oct 19, 2022

I've done a little test with a simple mapping

{
    "request": {
        "method": "GET",
        "url": "/simple"
    },
    "response": {
        "status": 200,
        "body": "Hello world!",
        "headers": {
            "Content-Type": "text/plain"
        }
    }
}

Which still works

@tomakehurst tomakehurst merged commit bfc5f1d into wiremock:master Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants