Fixed #1684 - Expose remove stub mapping by ID #1986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Generally this looks great. Please can you replace the two unit tests you've added with an acceptance test case (in |
Patrolfr
force-pushed
the
expose-remove-stub-mapping-by-id
branch
from
a5eea11
to
be397b8
Compare
|
Sure, replaced unit tests with acceptance ones. |
|
@tomakehurst Do you mind checking it again? Would be great to have the first PR merged 😉 |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, found this good first issue during Hacktoberfest.
The issue seems self-explanatory, I will be happy to hear any feedback.