Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new language #15485

Open
11257896 opened this issue Jul 22, 2023 · 17 comments
Open

Add new language #15485

11257896 opened this issue Jul 22, 2023 · 17 comments

Comments

@11257896
Copy link

11257896 commented Jul 22, 2023

Please add Sinhala language to the Wire web application.

Wire Web Application
https://crowdin.com/project/wire-webapp/si-LK
(Status: 100% completed)

Wire - Emails
https://crowdin.com/project/wire-launch/si-LK
(Status: 100% completed)

Contributor(s): https://crowdin.com/profile/helabasa

@11257896
Copy link
Author

11257896 commented Sep 4, 2023

You haven't added this language to the latest version. Can you please check this issue and accept our request? @tlebon @atomrc @lipis @ffflorian @bennycode @wireswiss

Status:
Wire Desktop: 100% completed (Available)
Wire Web: 100% completed (#15485)
Wire Emails: 100% completed (#15485)

Edited: Wire Android (New!): 97% (Available)
Wire iOS: - (Not enabled)

@tlebon
Copy link
Contributor

tlebon commented Sep 5, 2023

looking into this now.

@tlebon
Copy link
Contributor

tlebon commented Sep 5, 2023

@hanariyada please see all the wire emails here: https://wireapp.github.io/wire-emails/dist/

@tlebon
Copy link
Contributor

tlebon commented Sep 5, 2023

it seems si-LK is in the app? from my perspective. what exactly seems to be the issue here?

@11257896
Copy link
Author

11257896 commented Sep 5, 2023

@hanariyada please see all the wire emails here: https://wireapp.github.io/wire-emails/dist/

Please add Sinhala templates.

it seems si-LK is in the app? from my perspective. what exactly seems to be the issue here?

https://app.wire.com/auth/?hl=si
(or https://app.wire.com/auth/?hl=si_LK)

Wire repository: https://github.com/wireapp/wire-webapp/blob/dev/src/i18n/si-LK.json

image

Crowdin: https://crowdin.com/project/wire-webapp/si-LK

image

@tlebon
Copy link
Contributor

tlebon commented Sep 5, 2023

I see the issue now.
I have added Sinhala to the email templates for the time being. https://wireapp.github.io/wire-emails/dist/
It will also be added to the webapp in one of the next versions.

@11257896
Copy link
Author

Status:
Wire Desktop: 100% completed (Available)
Wire Web: 100% completed (#15485)
Wire Emails: 100% completed (#15485)
Wire Android (New!): 51% (Work-in-progress)
Wire iOS: - (Not enabled)

Wire Android (New!): 97%

image

@11257896
Copy link
Author

@tlebon, Just a kind reminder in case you didn't have time to look into this issue...
Let me know if you need more time or have any questions.

https://github.com/wireapp/wire-webapp/releases/tag/2023-10-19-production.0
image

@tlebon
Copy link
Contributor

tlebon commented Oct 21, 2023

Sorry from my side I am blocked on this currently. The translations need to be approved on crowdin and I don't have the 'power' to do this. I reached out to the relevant parties previously but I think it slipped through the cracks for this release.

What I can tell you is:
I am forwarding this conversation to them now and asking them to approve the translations and I hope that this time it will be in the next release.
I'm sorry and I hope we get this done for you as soon as possible. I will follow up when I have more information.
FYI this person is on vacation now so I don't think I will have an update for at least two weeks

@11257896
Copy link
Author

11257896 commented Jan 27, 2024

I hope that this time it will be in the next release.
The translations need to be approved on crowdin

@tlebon Please check now

https://github.com/wireapp/wire-webapp/releases/tag/2024-01-22-production.0
https://github.com/wireapp/wire-webapp/releases/tag/2024-01-22-production.1

@tlebon
Copy link
Contributor

tlebon commented Jan 29, 2024

@11257896 apologies! but if you look at the commits for that release it was just a hotfix (only a few new commits on top of a head 4 months old)...

If you check the SI-LK.json in the dev branch now you can see that it includes the translations! So it will be in the next full release!

Again I am really sorry for the delay!

Unfortunately, I do not have an ETA currently as QA is busy. I will mention the topic of just pushing translations in a team meeting tomorrow.

@tlebon
Copy link
Contributor

tlebon commented May 6, 2024

I believe this is closed now as Sinhala has been added. Please reopen if there is some other issue with it.

@tlebon tlebon closed this as completed May 6, 2024
@11257896
Copy link
Author

11257896 commented May 7, 2024

@tlebon You can use this links to test: https://app.wire.com/auth/?hl=si or https://app.wire.com/auth/?hl=si_LK

Please take a look at the attached screenshots.

Wire Settings
Link: https://app.wire.com/?hl=si_LK
Project: https://crowdin.com/project/wire-webapp (Sinhala - 100%)

Screenshot 2024-05-07 085807

Phone Login
Link: https://app.wire.com/auth/?hl=si#/phonelogin
Project: https://crowdin.com/project/wire-webapp (Sinhala - 100%)

Screenshot 2024-05-07 090237

Change Password Page
Link: https://account.wire.com/forgot/
Project: https://crowdin.com/project/wire-account (👇)

Screenshot 2024-05-07 090411

Delete Account Page(s)
Project: https://crowdin.com/project/wire-account (👇)

Screenshot 2024-05-07 092852

Wire E-mails
Project: https://crowdin.com/project/wire-launch (Sinhala - 100%)

E.g. Wire verification, New Device, Delete Account, etc.

Screenshot 2024-05-07 090734
Screenshot 2024-05-07 092449
Screenshot 2024-05-07 092822

Wire Teams Page
Link: https://teams.wire.com/register/email
Project: ?

Screenshot 2024-05-07 090517

Wire Desktop
Project-1: https://crowdin.com/project/wire-desktop (Sinhala - 100%)
Project-2:https://crowdin.com/project/wire-webapp (Sinhala - 100%)

(Steps to enable Sinhala: Wire -> Language -> සිංහල)

Screenshot 2024-05-07 091654

@11257896
Copy link
Author

11257896 commented May 7, 2024

@tlebon We like to translate this project into Sinhala language ☺️
https://crowdin.com/project/wire-account

@tlebon tlebon reopened this May 7, 2024
@tlebon
Copy link
Contributor

tlebon commented May 7, 2024

Oh noo, we arent importing the language now so it wasnt loading.
It will be included into the webapp in the next release, i made a PR for it now #17372.

Apologies for the delay, i thought this was finished as the translations were added. I have added sinhala to wire-account crowdin as well for you to translate now as well. I can look into the other missing locations also

@tlebon
Copy link
Contributor

tlebon commented May 7, 2024

ive also added sinhala here: https://crowdin.com/project/wire-team-settings

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants