Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unicode support missing for group titles #10866

Open
Wurzelkoch opened this issue Apr 6, 2021 · 2 comments
Open

Unicode support missing for group titles #10866

Wurzelkoch opened this issue Apr 6, 2021 · 2 comments

Comments

@Wurzelkoch
Copy link

Version 3.21.2936
Wire for Web Version 2021.04.01.08.46
Operating system: Linux 4.19.0-14-amd64 wireapp/wire-desktop#1 SMP Debian 4.19.171-2 (2021-01-30) x86_64 GNU/Linux
What steps will reproduce the problem?

  1. Create a new group with german Umlauts (eg ü) in the title

What is the expected result?

Title is shown as was the input.

What is the actual result?

Umlaut is shown only on android, while on desktop instead of an "ü" I see "ü".

Usernames containing Umlauts are shown as expected.

@ffflorian ffflorian transferred this issue from wireapp/wire-desktop Apr 6, 2021
@summic
Copy link

summic commented Apr 26, 2021

Chinese is also like this
And the search function is not working

@oomhj
Copy link

oomhj commented May 27, 2021

The issuse was caused by the BufferToString function in
api-client/src/shims/browser/buffer.ts

export const bufferToString = (buffer: ArrayBuffer): string => {
  let binaryString = '';
  const bytes = new Uint8Array(buffer);

  for (let index = 0; index < bytes.length; index++) {
    binaryString += String.fromCharCode(bytes[index]);
  }

  return binaryString;
};

String.fromCharCode(bytes[index]) Converts one byte directly to ASCII Char,not support UTF-8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants