Typings on LoggerOptions and Logger interfaces. #2021
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some typings are missing on index.d.ts.
Missing fields:
on LoggerOptions interface:
on Logger interface (suggested by DABH):
Missing interfaces (suggested by DABH):
This commit fix it (3 commits):
Issue: #1801
One workaround for part of the problem(only for missing fields on LoggerOptions) is doing a declaration merging on winston module.