Remove AppVeyor #1975
Remove AppVeyor #1975
Conversation
README.md
Outdated
| [](https://www.npmjs.com/package/winston) | ||
| [](https://npmcharts.com/compare/winston?minimal=true) | ||
| [](https://github.com/winstonjs/winston/actions/workflows/ci.yml) | ||
| [](https://david-dm.org/winstonjs/winston) |
|
Do I need to disable Appveyor in the repo settings or from the Appveyor site or? Let me know and I’ll give it a try (I think it’s my fault it’s there in the first place). That being said — The reason we added that in the first place was so that we could run the tests on windows, which sometimes behaved a little different than on Linux. Does GitHub actions support testing on multiple platforms? Should we still care, or hope that the ecosystem has matured enough that platform discrepancies shouldn’t be a concern? |
Yes, you need to tell AppVeyor to ignore this project so it stop it marking builds as failed. The last one failed because the |
|
@fearphage I think I have deleted the project from AppVeyor, hopefully we're good now? |
|
@DABH Looks like it didn't work. I merged to master and still see AppVeyor:
We should stop merging PRs until we get this fixed. They will all fail now. I believe you need to delete the project in AppVeyor. I'm guessing based on this ticket. stevengj/nlopt#421 |
|
Hmm I thought I did but might need to email @indexzero , I’ll do that… |
|
This is reported done by @indexzero. |
|
Confirmed in several PRs (#1986) and on the main branch. |
Most of the ReadMe changes are dead white space at the end of lines.
View without white space changes: https://github.com/winstonjs/winston/pull/1975/files?diff=unified&w=1
We need someone to disable AppVeyor so it doesn't erroneously fail builds.