Add typings for the isLevelEnabled(string) and isXXXEnabled() functions #1622
+17
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That looks fine to me. I think it's a reasonable policy to explicitly add isXXXEnabled() for any level that's supported out of the box in winston (but not for anybody's custom levels, of course -- they can just use isLevelEnabled). Thanks! |
DABH
approved these changes
Mar 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added types for
isLevelEnabled(level: string)andisXXXEnabled()for each of the default npm levels.Not sure what the best approach is for the
isXXXEnabled()functions. Let me know if you have any thoughts or would like to remove these altogether.Resolves #1621