Skip to content

fix typo related to exitOnError #1559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 3, 2019
Merged

fix typo related to exitOnError #1559

merged 1 commit into from
Jan 3, 2019

Conversation

eubnara
Copy link
Contributor

@eubnara eubnara commented Jan 2, 2019

When I was reading #1355, I found some awkward lines to me.

This might be not that important but I think the log messages are wrong and it might make readers confused.

@DABH
Copy link
Contributor

DABH commented Jan 2, 2019

Wow, yeah I think you're right about that! Could you possibly also fix these messages in rejection-handler.js ? Then I can merge. Thanks very much!

@eubnara
Copy link
Contributor Author

eubnara commented Jan 2, 2019

@DABH
I changed it. Thanks for your fast feedback.

@DABH
Copy link
Contributor

DABH commented Jan 3, 2019

Cool, thanks!

@DABH DABH merged commit 664b44b into winstonjs:master Jan 3, 2019
Mizumaki pushed a commit to Mizumaki/winston that referenced this pull request Jun 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants